Commit e3eefcdf authored by tasc's avatar tasc Committed by Florent Torregrosa
Browse files

Issue #3245705 by tasc, Grimreaper, apaderno: Make tracking of 404/403 pages... 

Issue #3245705 by tasc, Grimreaper, apaderno: Make tracking of 404/403 pages optional. Fix PHP CPD and PHP CS
parent 794958e2

config/install/matomo.settings.yml

+1 −0
Original line number Diff line number Diff line
@@ -29,3 +29,4 @@ disable_tracking: false 
cache: false

page_title_hierarchy: false

page_title_hierarchy_exclude_home: true

status_codes_disabled: {  }

config/schema/matomo.schema.yml

+6 −0
Original line number Diff line number Diff line
@@ -124,3 +124,9 @@ matomo.settings: 
    page_title_hierarchy_exclude_home:

      type: boolean

      label: 'Hide home page from hierarchy'

    status_codes_disabled:

      type: sequence

      label: 'Status codes disabled'

      sequence:

        type: string

        label: 'Status code'

js/matomo.admin.js

+14 −0
Original line number Diff line number Diff line
@@ -125,6 +125,20 @@ 
        return Drupal.t('@items enabled', {'@items': vals.join(', ')});

      });



      $('#edit-status-codes').drupalSetSummary(function (context) {

        var vals = [];

        if ($('input#edit-status-codes-disabled-404', context).is(':checked')) {

          vals.push(Drupal.t('404'));

        }

        if ($('input#edit-status-codes-disabled-403', context).is(':checked')) {

          vals.push(Drupal.t('403'));

        }

        if (!vals.length) {

          return Drupal.t('Default');

        }

        return Drupal.t('@items disabled', {'@items': vals.join(', ')});

      });



      $('#edit-privacy').drupalSetSummary(function (context) {

        var vals = [];

        if ($('input#edit-matomo-privacy-donottrack', context).is(':checked')) {

matomo.install

+10 −0
Original line number Diff line number Diff line
@@ -99,3 +99,13 @@ function matomo_update_8102() { 
  $config->set('disable_tracking', FALSE);

  $config->save(TRUE);

}



/**

 * Add new disable status codes setting to Matomo default configuration.

 */

function matomo_update_8103() {

  $config_factory = \Drupal::configFactory();

  $config = $config_factory->getEditable('matomo.settings');

  $config->set('status_codes_disabled', []);

  $config->save(TRUE);

}

matomo.module

+7 −0
Original line number Diff line number Diff line
@@ -60,6 +60,13 @@ function matomo_page_attachments(array &$page) { 
  if ($exception) {

    $status = $exception->getStatusCode();

  }



  // Early return if status matches configured values.

  $disabled_status_codes = $config->get('status_codes_disabled');

  if (in_array($status, $disabled_status_codes)) {

    return;

  }



  $trackable_status_codes = [

    // "Forbidden" status code.

    '403',