>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3394021. --> Reported by: [karolinam](https://www.drupal.org/user/3434943) Related to !5 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>PHP Unit test failing and PHPCS is reporting errors after ugrading masquerade to revision 2.0.0-rc4 and PHP8.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Run PHPUnit tests and PHPCS.</p> <h4>PHPUnit</h4> <pre>Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testMasqueradeAsRole<br>Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user<br>/builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:29<br>/builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728<br>3) Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testCleanupRegular<br>Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user<br>/builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:73<br>/builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728<br>4) Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::testMasqueradeAsRoleCron<br>Undefined property: Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user<br>/builds/wsg/drupal9/web/modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php:95<br>/builds/wsg/drupal9/vendor/phpunit/phpunit/src/Framework/TestResult.php:728</pre><p>PHPStan reports the same errors:</p> <pre>------ ------------------------------------------------------------------------------------------------------------------- <br>&nbsp; Line&nbsp;&nbsp; modules/contrib/masquerade_as_role/tests/src/Functional/MasqueradeAsRoleTest.php&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------- <br>&nbsp; 29&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 34&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$auth_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 39&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 41&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role.&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 42&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role.&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 45&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 46&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 53&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 55&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 63&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 73&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 77&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role.&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 78&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role.&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 95&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$admin_user.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 99&nbsp;&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$editor_role.&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br>&nbsp; 100&nbsp;&nbsp;&nbsp; Access to an undefined property Drupal\Tests\masquerade_as_role\Functional\MasqueradeAsRoleTest::$moderator_role.&nbsp; <br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#128161; Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <br> ------ ------------------------------------------------------------------------------------------------------------------- </pre><h4>PHPCS</h4> <pre>----------------------------------------------------------------------<br>FILE: ...s/contrib/masquerade_as_role/src/Controller/SwitchController.php<br>----------------------------------------------------------------------<br>FOUND 1 ERROR AFFECTING 1 LINE<br>----------------------------------------------------------------------<br> 7 | ERROR | [x] Use statements should be sorted alphabetically. The<br>&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp; first wrong one is<br>&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp; Drupal\masquerade\Controller\SwitchController.<br>----------------------------------------------------------------------<br>PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br>----------------------------------------------------------------------<br>FILE: ...web/modules/contrib/masquerade_as_role/masquerade_as_role.module<br>----------------------------------------------------------------------<br>FOUND 1 ERROR AFFECTING 1 LINE<br>----------------------------------------------------------------------<br> 9 | ERROR | [x] Use statements should be sorted alphabetically. The<br>&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp; first wrong one is<br>&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp;&nbsp;&nbsp; Drupal\Core\Block\BlockPluginInterface.<br>----------------------------------------------------------------------</pre><h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Member variable names were changed in the base class MasqueradeWebTestBase. See <a href="https://git.drupalcode.org/project/masquerade/-/commit/8a9cb9ded6c72787b5521c18b641a78e062e5a11">https://git.drupalcode.org/project/masquerade/-/commit/8a9cb9ded6c72787b5521c18b641a78e062e5a11</a><br> Use the new variable names.</p>