Doublecheck settings being merged
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #3533958. -->
Reported by: [ultimike](https://www.drupal.org/user/51132)
Related to !25
>>>
<p>Relocated from <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/markdown_easy/-/work_items/3531327" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/markdown_easy/-/work_items/3531327</a></span>:</p>
<blockquote><pre>public function settingsForm(array $form, FormStateInterface $form_state): array {<br> $this->settings = array_replace_recursive($this->defaultSettings(), $this->settings);</pre><p>The fact that <code>defaultSettings()</code> are only merged in <code>settingsForm()</code>, and not in the constructor or <code>process()</code>, feels off. That said, it might be 100% valid. I'm thinking that if the filter ever processes text without the form being loaded first, it could result in unexpected behavior? I wonder if it makes more sense to initialize <code>$this->settings</code> in the constructor.</p></blockquote>
issue