From 870317a3102e5494056cc79edae1f5dae054e191 Mon Sep 17 00:00:00 2001
From: MegaChriz <megachriz@hotmail.com>
Date: Mon, 24 Mar 2025 12:04:35 +0100
Subject: [PATCH 1/3] Added test coverage.
---
tests/src/Functional/FilterAdminTest.php | 38 ++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/tests/src/Functional/FilterAdminTest.php b/tests/src/Functional/FilterAdminTest.php
index 3059f5b..f888f42 100644
--- a/tests/src/Functional/FilterAdminTest.php
+++ b/tests/src/Functional/FilterAdminTest.php
@@ -2,6 +2,8 @@
namespace Drupal\Tests\markdown\Functional;
+use Drupal\editor\EditorInterface;
+use Drupal\editor\Entity\Editor;
use Drupal\filter\Entity\FilterFormat;
use Drupal\filter\FilterFormatInterface;
use Drupal\markdown\Plugin\Filter\FilterMarkdownInterface;
@@ -60,4 +62,40 @@ class FilterAdminTest extends MarkdownBrowserTestBase {
$this->assertTrue($markdown->isEnabled());
}
+ /**
+ * Tests creating a text format using CKEditor without the markdown filter.
+ */
+ public function testCreateTextFormatWithoutMarkdownFilter() {
+ // Enable the CKEditor5 module.
+ $this->container->get('module_installer')->install(['ckeditor5']);
+
+ // Add text format.
+ $this->drupalGet('admin/config/content/formats/add');
+
+ $format_id = $this->randomMachineName();
+ $edit = [
+ 'format' => $format_id,
+ 'name' => $this->randomMachineName(),
+ 'editor[editor]' => 'ckeditor5',
+ ];
+ $this->submitForm($edit, 'Configure');
+
+ // Workaround for https://www.drupal.org/project/drupal/issues/3457717.
+ $edit = [
+ 'editor[settings][toolbar][items]' => '["heading","bold","italic","drupalInsertImage"]',
+ ];
+ $this->submitForm($edit, 'Configure');
+ $this->submitForm([], 'Save configuration');
+ $this->assertSession()->statusCodeEquals(200);
+
+ // Check that the filter has been created.
+ $format = FilterFormat::load($format_id);
+ $this->assertInstanceof(FilterFormatInterface::class, $format);
+
+ // Check that CKEditor5 is enabled for this format.
+ $editor = Editor::load($format_id);
+ $this->assertInstanceof(EditorInterface::class, $editor);
+ $this->assertEquals('ckeditor5', $editor->getEditor());
+ }
+
}
--
GitLab
From c63e053b038f6c4cf27cc69e9c17f4c30ef14aaf Mon Sep 17 00:00:00 2001
From: MegaChriz <megachriz@hotmail.com>
Date: Mon, 24 Mar 2025 16:47:39 +0100
Subject: [PATCH 2/3] Test with league/commonmark.
---
composer.json | 3 +++
1 file changed, 3 insertions(+)
diff --git a/composer.json b/composer.json
index eb2df1e..098d1b0 100644
--- a/composer.json
+++ b/composer.json
@@ -25,6 +25,9 @@
"php": ">=5.5.9",
"composer/semver": "^1.0 || ^2.0 || ^3.0"
},
+ "require-dev": {
+ "league/commonmark": "^1.6"
+ }
"suggest": {
"league/commonmark": "The PHP CommonMark parser is a robust, highly-extensible Markdown parser for PHP based on the CommonMark and Github-Flavored Markdown specifications."
},
--
GitLab
From f7cc851127504ed0cc501a8f3254589480520b40 Mon Sep 17 00:00:00 2001
From: MegaChriz <megachriz@hotmail.com>
Date: Mon, 24 Mar 2025 16:56:46 +0100
Subject: [PATCH 3/3] Forgot to add comma in composer.json.
---
composer.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/composer.json b/composer.json
index 098d1b0..407701f 100644
--- a/composer.json
+++ b/composer.json
@@ -27,7 +27,7 @@
},
"require-dev": {
"league/commonmark": "^1.6"
- }
+ },
"suggest": {
"league/commonmark": "The PHP CommonMark parser is a robust, highly-extensible Markdown parser for PHP based on the CommonMark and Github-Flavored Markdown specifications."
},
--
GitLab