>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3414438. --> Reported by: [roderik](https://www.drupal.org/user/8841) Related to !78 !77 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>breadcrumbs in CE API output have a URL pointing to the backend.</p> <p>See screenshot, or test-fail MR whose phpunit test outputs</p> <pre>There was 1 failure:<br><br>1) Drupal\Tests\lupus_decoupled\Functional\LupusDecoupledApiResponseTest::testSchemaBreadcrumbs<br>Breadcrumb 0 must start with the frontend base URL.<br>Failed asserting that 'https://lupus-decoupled.ddev.site:8443/' starts with "https://lupus-nuxt.ddev.site:8443".</pre><h4 id="summary-steps-reproduce">Steps to reproduce</h4> <ul> <li>Enable lupus_decoupled_schema_metatag module (or only schema_metatag module; the only difference is in where exactly the breadcrumbs are visible.)</li> <li>In configuration - metatag - any node type: Edit settings "Schema.org: WebPage - breadcrumbs", set to Yes</li> <li>View API output of corresponding node</li> </ul> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Discussed:</p> <p>LupusFrontendPathProcessor::processOutbound() currently only changes URLs that have a (configured) front end path, if these have a 'entity' option.</p> <p>Instead: always change URLs that have a (configured) front end path. If they don't have a 'entity' option, then change them to the 'default' front end base URL.</p> <h3>Complications with this resolution</h3> <p>Dropping the restriction on <code>$options['entity']</code> has the effect that several other kinds of links are having the frontend URL appended. Often this is unnecessary. To fix this, <code>$request-&gt;getRequestFormat() != 'custom_elements')</code> was basically changed to <code>$request-&gt;getRequestFormat() != 'custom_elements') &amp;&amp; !$request-&gt;attributes-&gt;get('lupus_ce_renderer', FALSE)</code> while reviewing this issue.</p> <h3>NOTE - behavior change</h3> <p>The <code>lupus_decoupled_ce_api.frontend_paths</code> services parameter has "/" added. This is necessary for making the breadcrumb links to 'home' in the ld+json payload point to the frontend (not the backend -- they are always absolute).</p> <p>This has an added effect of making "Home" links on the backend also point to the frontend homepage. They pointed to the backend before.</p> <p>We basically cannot distinguish one from the other, without adding extra logic.</p> <h3><em>Complications with this resolution - obsolete comments:</em></h3> <p><strong>1)</strong>The original restriction was;</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br></span><span style="color: #007700">if (</span><span style="color: #0000BB">$absolute </span><span style="color: #007700">|| </span><span style="color: #0000BB">$request</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">getRequestFormat</span><span style="color: #007700">() != </span><span style="color: #DD0000">'custom_elements'</span><span style="color: #007700">) {<br>&nbsp; </span><span style="color: #0000BB">change to an absolute link pointing to frontend<br>?&gt;</span></span></pre></div> <p><strong>2)</strong>This evolved to;</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br></span><span style="color: #007700">if (</span><span style="color: #0000BB">$absolute </span><span style="color: #007700">|| !</span><span style="color: #0000BB">in_array</span><span style="color: #007700">(</span><span style="color: #0000BB">$request</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">getRequestFormat</span><span style="color: #007700">(), [</span><span style="color: #0000BB">NULL</span><span style="color: #007700">, </span><span style="color: #DD0000">'json'</span><span style="color: #007700">, </span><span style="color: #DD0000">'custom_elements'</span><span style="color: #007700">], </span><span style="color: #0000BB">TRUE</span><span style="color: #007700">)) {<br>&nbsp; </span><span style="color: #0000BB">change to an absolute link pointing to frontend<br>?&gt;</span></span></pre></div> <p>... it's likely fairly obvious that the 'json' format should be exempted from this. But the NULL format is also necessary if we want to prevent redirects <em>specifically implemented through the Redirect module</em> in API output, to be changed from relative to absolute unnecessarily. (Because the redirect module intercepts the REQUEST event, before the lupus_ce_renderer module sets the request format.)</p> <p>(I'm trying to write a phpunit test to include here, to enforce that links handled by the Redirect module will stay relative. However I'm having some issues with that at the moment.)</p> <p><strong>3)</strong>I am experimenting with instead doing</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br></span><span style="color: #007700">if (</span><span style="color: #0000BB">$absolute </span><span style="color: #007700">|| !</span><span style="color: #0000BB">$request</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">attributes</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">get</span><span style="color: #007700">(</span><span style="color: #DD0000">'lupus_ce_renderer'</span><span style="color: #007700">, </span><span style="color: #0000BB">FALSE</span><span style="color: #007700">)) {<br>&nbsp; </span><span style="color: #0000BB">change to an absolute link pointing to frontend<br>?&gt;</span></span></pre></div> <p>Because frankly, it looks more straightforward to me... and it also solves another issue in our internal product.</p> <p>Some of our internal tests are still failing, but it looks like that might mean our internal code should change instead. To be continued.</p>