>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3396419. --> Reported by: [m.stenta](https://www.drupal.org/user/581414) Related to !13 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Currently the <code>timestamp</code> base field on Log entities is not required, but it is always populated with a default value if it is left blank.</p> <p>Technically speaking, all logs MUST have a timestamp. It is a critical piece of their data architecture.</p> <p>This came to my attention recently when users of <a href="https://www.drupal.orgdrupal.org/project/farm/">farmOS</a> pointed out that <code>timestamp</code> is not marked as required in the JSON Schema.</p> <p>I tried to dig back in time to figure out why they weren't required, and I traced it to this issue: <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/log/-/work_items/3176676" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/log/-/work_items/3176676</a></span></p> <p>In that issue, we (at my direction, so I take the blame haha), removed <code>setRequired(TRUE)</code> because I said: "Make timestamp and state fields not required in form (timestamp will be autofilled)". We later rolled back the <code>state</code> field change.</p> <p>Seeing that, I was worried that we were a bit stuck, because it might be a breaking change to make it required now. My thought was that if there were any users would pushed logs via API without timestamp (relying on the auto-populated timestamp), that code would break because it would require a timestamp be set. However, in testing this, I found that the default value gets populated *before* the check is performed, so it is *still* possible to submit a log without a timestamp, and it works exactly the same as before.</p> <p>So as far as I can tell, this change would not break anything.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Add <code>setRequired(TRUE)</code> on <code>timestamp</code> base field.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>Create MR.</p> <h3 id="summary-ui-changes">User interface changes</h3> <p>Timestamp will be marked as required in log form UI.</p> <h3 id="summary-api-changes">API changes</h3> <p>Timestamp will be marked as required in JSON Schema when using JSON:API Schema module.</p> <h3 id="summary-data-model-changes">Data model changes</h3> <p>Timestamp will be required at the entity definition level.</p>