From 0bc610db0d6fcb75893a0629f7270702be9ae42c Mon Sep 17 00:00:00 2001 From: Girish <girish.guntaka@gmail.com> Date: Thu, 20 Mar 2025 03:13:32 +0000 Subject: [PATCH] Issue #3514212: Fix issues reported by PHPCS --- css/builder.css | 12 +++--------- .../layout-paragraphs-builder-formatter.html.twig | 2 +- .../layout-paragraphs-builder-section-menu.html.twig | 2 +- templates/layout-paragraphs-builder.html.twig | 2 +- .../templates/paragraph--section.html.twig | 1 - .../templates/paragraph--text.html.twig | 1 - tests/src/FunctionalJavascript/BlockFieldTest.php | 1 - tests/src/FunctionalJavascript/FormRenderingTest.php | 1 - .../src/FunctionalJavascript/NestedSectionsTest.php | 1 - 9 files changed, 6 insertions(+), 17 deletions(-) diff --git a/css/builder.css b/css/builder.css index 8153ed31..e1c3b62d 100644 --- a/css/builder.css +++ b/css/builder.css @@ -53,9 +53,7 @@ outline: 1px dotted rgba(0, 0, 255, 0.5); } .lp-builder:not(.is-navigating) .js-lpb-component:hover .js-lpb-region:hover, -.lp-builder:not(.is-navigating) - .js-lpb-component:focus-within - .js-lpb-region:focus-within { +.lp-builder:not(.is-navigating) .js-lpb-component:focus-within .js-lpb-region:focus-within { outline: 1px solid rgba(0, 0, 255, 0.5); } .lpb-layout { @@ -85,9 +83,7 @@ opacity: 0; border-radius: 0 0 6px 0; background-color: #fff; - box-shadow: - 0 1px 1px rgba(0, 0, 0, 0.25), - 0 1px 3px rgba(0, 0, 0, 0.25); + box-shadow: 0 1px 1px rgba(0, 0, 0, 0.25); } .lpb-controls:hover, .lpb-controls:focus-within { @@ -264,9 +260,7 @@ background-color: #fff; background-image: url("data:image/svg+xml,%3Csvg width='24' height='24' viewBox='0 0 24 24' fill='none' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath opacity='.5' fill-rule='evenodd' clip-rule='evenodd' d='M13 6V11H18V13H13V18H11V12.999L6 13V11L11 10.999V6H13Z' fill='%23130F13'/%3E%3C/svg%3E%0A"); background-size: cover; - box-shadow: - 0 1px 1px rgba(0, 0, 0, 0.25), - 0 1px 3px rgba(0, 0, 0, 0.25); + box-shadow: 0 1px 1px rgba(0, 0, 0, 0.25); } .lpb-btn--add:hover { opacity: 1; diff --git a/templates/layout-paragraphs-builder-formatter.html.twig b/templates/layout-paragraphs-builder-formatter.html.twig index 8eea35d9..0c58022a 100644 --- a/templates/layout-paragraphs-builder-formatter.html.twig +++ b/templates/layout-paragraphs-builder-formatter.html.twig @@ -14,4 +14,4 @@ </div> </div> {{ root_components }} -{% endif %} \ No newline at end of file +{% endif %} diff --git a/templates/layout-paragraphs-builder-section-menu.html.twig b/templates/layout-paragraphs-builder-section-menu.html.twig index 507c1bd5..ac9425ea 100644 --- a/templates/layout-paragraphs-builder-section-menu.html.twig +++ b/templates/layout-paragraphs-builder-section-menu.html.twig @@ -12,4 +12,4 @@ </div> {% endfor %} </div> -</div> \ No newline at end of file +</div> diff --git a/templates/layout-paragraphs-builder.html.twig b/templates/layout-paragraphs-builder.html.twig index e0f4b1e2..dcd44244 100644 --- a/templates/layout-paragraphs-builder.html.twig +++ b/templates/layout-paragraphs-builder.html.twig @@ -16,4 +16,4 @@ {{ root_components }} </div> {% endif %} -</div> \ No newline at end of file +</div> diff --git a/tests/modules/layout_paragraphs_translations_test/templates/paragraph--section.html.twig b/tests/modules/layout_paragraphs_translations_test/templates/paragraph--section.html.twig index feaf4dc5..33dc0a5b 100644 --- a/tests/modules/layout_paragraphs_translations_test/templates/paragraph--section.html.twig +++ b/tests/modules/layout_paragraphs_translations_test/templates/paragraph--section.html.twig @@ -54,4 +54,3 @@ {% endblock %} </div> {% endblock paragraph %} - diff --git a/tests/modules/layout_paragraphs_translations_test/templates/paragraph--text.html.twig b/tests/modules/layout_paragraphs_translations_test/templates/paragraph--text.html.twig index 3d0f1d90..f918a660 100644 --- a/tests/modules/layout_paragraphs_translations_test/templates/paragraph--text.html.twig +++ b/tests/modules/layout_paragraphs_translations_test/templates/paragraph--text.html.twig @@ -54,4 +54,3 @@ {% endblock %} </div> {% endblock paragraph %} - diff --git a/tests/src/FunctionalJavascript/BlockFieldTest.php b/tests/src/FunctionalJavascript/BlockFieldTest.php index 3e37d3a9..a797a53a 100644 --- a/tests/src/FunctionalJavascript/BlockFieldTest.php +++ b/tests/src/FunctionalJavascript/BlockFieldTest.php @@ -47,7 +47,6 @@ class BlockFieldTest extends BuilderTestBase { 'search content', ]); $this->drupalGet('node/add/page'); - $page = $this->getSession()->getPage(); $this->addSectionComponent(2, '.lpb-btn--add'); $this->addBlockFieldComponent('search_form_block', '.layout__region--first .lpb-btn--add'); $this->addTextComponent('Some arbitrary text', '.layout__region--first .lpb-btn--add.after'); diff --git a/tests/src/FunctionalJavascript/FormRenderingTest.php b/tests/src/FunctionalJavascript/FormRenderingTest.php index 00823e16..d9169639 100644 --- a/tests/src/FunctionalJavascript/FormRenderingTest.php +++ b/tests/src/FunctionalJavascript/FormRenderingTest.php @@ -36,7 +36,6 @@ class FormRenderingTest extends BuilderTestBase { ]); $this->drupalGet('node/add/page'); - $page = $this->getSession()->getPage(); $this->addSectionComponent(0, '.lpb-btn--add'); // Make sure the "Test field" form element appears. diff --git a/tests/src/FunctionalJavascript/NestedSectionsTest.php b/tests/src/FunctionalJavascript/NestedSectionsTest.php index 388e7d41..f1e1c6f7 100644 --- a/tests/src/FunctionalJavascript/NestedSectionsTest.php +++ b/tests/src/FunctionalJavascript/NestedSectionsTest.php @@ -38,7 +38,6 @@ class NestedSectionsTest extends BuilderTestBase { ]); $this->drupalGet('node/add/page'); - $page = $this->getSession()->getPage(); // Add a two-column section. $this->addSectionComponent(1, '.lpb-btn--add'); -- GitLab