>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3619065. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !50 >>> <p>A second naming audit, re-derived from scratch rather than from the first one's notes, so its blind spots could not propagate. Every kessai identifier was recounted against a fresh corpus of 23,405 core class, interface, trait, enum and method names: 930 identifiers, 512 of them in production code. The first audit's conclusions were then diffed against the result.</p> <p>Most of it held. All 72 files that declare a type are named for it, all 9 interfaces end <code>Interface</code>, all 209 test method names pass the phpcs lowerCamel rule, service ids are <code>plugin.manager.</code>, <code>logger.channel.</code> or module-prefixed, and the "deliberately kept" payment vocabulary survives re-derivation. Two things did not hold.</p> <h3><span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3618948" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3618948</a></span> describes work that never landed</h3> <p>Its "Agent nouns core never forms" section promised four renames and delivered one. <code>WorldlinePaymentFinalizer</code>, <code>PaymentAuditTrailBridge</code>, its <code>record()</code> callback and <code>WorldlineGateway::paymentAccepted()</code> are all still there. That last one sat thirty lines above <code>isPaymentCanceledByConsumer()</code>, which did take its prefix, so one file disagreed with itself.</p> <p>Core has no <code>Finalizer</code> at all, and its only two <code>Bridge</code> identifiers are <code>AnnotationBridgeDecorator</code> and <code>AttributeBridgeDecorator</code>, where the noun is <code>Decorator</code>; it has 231 <code>Handler</code> and 129 <code>Subscriber</code>. 95 of its 109 EventSubscriber classes end <code>Subscriber</code>, and its subscriber callbacks are <code>on</code> plus the event. So the four land as promised, and the service id follows the class: <code>kessai_worldline.finalizer</code> becomes <code>kessai_worldline.payment_handler</code>. <code>finalize()</code> stays a verb, which core uses too (<code>finalizePurge</code>, <code>finalizeValidation</code>).</p> <h3>Three the first audit missed</h3> <ul> <li><code>takeOperationLock()</code> becomes <code>acquireOperationLock()</code>. Core's verb for this is <code>acquire</code>, as in <code>LockBackendInterface::acquire()</code>; <code>take</code> appears once in the whole of core.</li> <li><code>PaymentGatewayInterface::defaultDeadline()</code> becomes <code>getDefaultDeadline()</code>. A bare noun returning a value, on an <code>@api</code> interface.</li> <li><code>PaymentManagerInterface::latestMovement()</code> becomes <code>getLatestMovement()</code>. The first audit renamed this method's parameter and never questioned the method.</li> </ul> <p>Left alone on the same surface: <code>authorizeToken()</code>, <code>expireDue()</code> and <code>checkoutReturnMatches()</code> all read as verb phrases, and <code>amountMatches()</code> and <code>cardExpiresBeforeDeadline()</code> are predicates rather than accessors.</p> <h3>A limit of the method, worth recording</h3> <p>The corpus count does not apply to test method names. They are deliberately sentences, so ordinary English ("what", "it", "says", "keeps", "goes") shows up as invented vocabulary: 188 zero-hit words across the module against 62 in production. Only the production figure means anything, and of those 62 the large majority are payment vocabulary core has no word for.</p> <h3>Breaking changes, and why they are free here</h3> <p>Two of these are on <code>@api</code> interfaces, and the audit trail subscriber is registered by its fully qualified class name, so the class name is its service id. In principle a third-party gateway plugin or anything injecting <code>kessai_worldline.finalizer</code> would break. In practice nothing does: every renamed symbol, fully qualified forms included, returns zero hits in both consuming modules, neither of which references <code>PaymentGatewayInterface</code> or <code>PaymentGatewayBase</code> at all, so nobody implements the gateway interface. The 25 references to <code>PaymentManagerInterface</code> call ten methods and <code>latestMovement()</code> is not among them. Kessai is pre-1.0 and reinstall-only, and migration paths start at beta.</p> <p>AI-Generated: Yes (Claude Code was used to run the audit, draft this summary and write the renames on the merge request. I reviewed and ran the work myself before posting it.)</p>