>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3619031. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !49 >>> <p><span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3618948" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3618948</a></span> moved the tests off <code>entity_test</code> and onto <code>user</code>, because core had started excluding its own test modules from release packages and the <code>dev-main</code> archive no longer carried it: every kernel class naming it errored before asserting anything.</p> <p>Core has reverted that packaging change (<code>34b130bd</code> on main, reverting <code>5341dd83</code>), so the reason is gone. It stood for under four hours.</p> <p>Reverting is the better end state. <code>entity_test</code> is a purpose-built generic entity with no behaviour of its own, which is exactly what a payment subject should be in a test: the subject is a type and an id the engine never interprets. A user brings real baggage to that role, a unique name among it, and reads as though the test cared which entity it was. So the tests go back to what they said before, and the naming work from <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3618948" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3618948</a></span> is untouched.</p> <p>This is not a bet that core will leave it alone. drupal <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-13"><a href="https://www.drupal.org/project/drupal/issues/3067979" title="Status: Needs work">#3067979: Exclude test files from release packages</a></span> is still Needs work, and <code>core/.gitattributes</code> keeps <code>modules/*/tests/src/</code> deliberately so contrib can still extend core's test base classes. What it strips is the test modules those base classes install, so a project cannot avoid the ones <code>WebDriverTestBase</code> and <code>PerformanceTestBase</code> add for it. Kessai extends only <code>KernelTestBase</code> and <code>BrowserTestBase</code> and names no other core test module, so when the exclusion returns the fix here is one line per class, not a redesign.</p> <h3>Also here: the key patch on the next-major lane</h3> <p>Folded in rather than filed separately. key discovers its plugins by annotation, which core 12 removes outright, so <code>KeyPluginManager</code> raises "only supports annotation-based discovery" and every kessai_audit_trail test errors before asserting anything: 8 errors against 201 passing, none of them about kessai. It reaches us two levels down, through kessai_audit_trail to audit_trail to key.</p> <p><code>_LENIENT_ALLOW_LIST</code> already gets key past composer and the module installer; it cannot make its code run. The upstream change exists as a merge request on key <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-4"><a href="https://www.drupal.org/project/key/issues/3484086" title="Status: Postponed">#3484086: Add attributes to plugins in addition to annotations</a></span>, so <code>.gitlab-ci/next-major-patches.json</code> points at that diff rather than carrying a copy, the same way pdv handles its six next-major dependencies. <code>COMPOSER_EXIT_ON_PATCH_FAILURE</code> is set because composer-patches otherwise writes "Could not apply patch! Skipping." and lets composer succeed, which would leave a green composer job beside a phpunit job failing on the original fatal.</p> <p>Verified before pushing: the diff applies to the installed key 1.22.0, and the patched manager passes an Attribute class as core's fifth constructor argument, so core's <code>is_subclass_of()</code> check takes the attribute path instead of throwing. One known gap, recorded in the CI comment: the diff predates key's state key provider, which keeps only its annotation and is therefore not discovered on core 12. Nothing here asks for that provider, since audit_trail reads keys through <code>KeyRepositoryInterface</code>, which is provider-agnostic.</p> <p>AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the revert on the merge request. I reviewed and ran the work myself before posting it.)</p>