>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3614236. --> Reported by: [mably](https://www.drupal.org/user/3375160) Related to !25 >>> <p>Three leftovers from the alpha2 audit, grouped because they are one job: making the module say what it means before another alpha goes out. All three are cheap, and all three get more expensive the longer a released tag carries them.</p> <h3>Nothing is marked @api</h3> <p>There is not a single <code>@api</code> marker in the project. That was noted at alpha1 and deferred, and it matters more now: the <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3614067" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3614067</a></span> series reshaped <code>PaymentGatewayInterface</code> three times in one go, so a reader has no way to tell which parts a consumer may rely on and which are internal. Pre-1.0 that is survivable; shipping 1.0 without it means every class becomes a promise by default.</p> <p>The surface to mark is roughly: <code>PaymentManagerInterface</code>, <code>PaymentInterface</code>, <code>PaymentGatewayInterface</code>, the two capability interfaces, <code>CheckoutSession</code>, <code>PaymentDeadline</code>, <code>ReconcileOutcome</code>, <code>PaymentEvents</code>, <code>PaymentEvent</code> and the exception hierarchy. Deciding what is deliberately <em>not</em> in it is the actual work.</p> <h3>The deadline is still called a time-to-live in config</h3> <p>The <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3614081" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3614081</a></span> series replaced time-to-live with deadline everywhere a person reads: the settings form says <strong>Default payment deadline</strong>, the value object is <code>PaymentDeadline</code>, the documentation says deadline. The config key is still <code>kessai.settings:default_payment_ttl</code>, and <code>PaymentManagerInterface::create()</code> still takes <code>$ttl</code>.</p> <p>So a site reads one word in the interface and writes another in its config export, and a consumer calling the API meets a third spelling of the same idea. Pre-1.0 and reinstall-only, so the key and the parameter can simply be renamed.</p> <h3>The French says language where the point is that it is not a language</h3> <p>The Worldline form shows <em>Locale par langue</em> directly above <em>Langue par d&eacute;faut de la page h&eacute;berg&eacute;e</em>. The whole argument of <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/kessai/-/work_items/3614193" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/kessai/-/work_items/3614193</a></span> is that a Drupal language code is not a provider locale, which is why the mapping exists at all, and the French for the fallback field calls it a language. It should read <em>Locale par d&eacute;faut de la page h&eacute;berg&eacute;e</em>.</p> <h3>Scope</h3> <p>Renaming the config key touches the schema, the install config, the form, the manager and the tests, and the parameter rename touches every caller. Both are mechanical. The <code>@api</code> pass is judgement rather than typing, and should not be rushed to fit alongside them if it turns out to need its own discussion.</p>