GitLab Acceleration Initiative meeting on 6 Apr, 2022
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #3273793. -->
Reported by: [hestenet](https://www.drupal.org/user/54034)
>>>
<p>This meeting:<br>
➤ Is for core developers, initiative contributors, the Drupal Association and anyone interested in the initiative.<br>
➤ Usually happens every other Wednesday at 11:00 PT / Thursday 06:00 UTC<br>
➤ Is done over chat.<br>
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!<br>
➤ Lots of threads get posted all at once! Don't worry - start at the top and then jump into the threads that most interest you.<br>
➤ Has a public agenda anyone can add to in the issue<br>
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.</p>
<p>ping: @mixologic @FeyP @bbrala @jurgenhaas (go to the issue of the next meeting to add or remove yourself from the list)</p>
<h2>Transcript</h2>
<h2>0️⃣ Who is here today? Comment in the thread below to introduce yourself!</h2>
<table>
<tr>
<td>Björn Brala (bbrala)</td>
<td>Ha! Lurking :smile:</td>
</tr>
<tr>
<td>hestenet (he/him)</td>
<td>Tim from the DA kicking off this meeting. :slightly_smiling_face:</td>
</tr>
<tr>
<td>Björn Brala (bbrala)</td>
<td>I should have a goto hi I'm here... :thinking_face:</td>
</tr>
<tr>
<td>mixologic</td>
<td>Ryan, from the DA</td>
</tr>
<tr>
<td>irinaz</td>
<td>Irina, working from Mountain View</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>Sascha from GitLab :wave: (edited)</td>
</tr>
<tr>
<td>markdorison</td>
<td>Mark from Chromatic :pikachu_wave:</td>
</tr>
<tr>
<td>moshe</td>
<td>:wave:</td>
</tr>
<tr>
<td>sugaroverflow</td>
<td>:wave::skin-tone-3: Fatima from GitLab checking in late</td>
</tr>
<tr>
<td>kimb0</td>
<td>Kim from Sydney</td>
</tr>
</table>
<h2>1️⃣ Do you have any topics to propose for the meeting today? Feel free to propose them in this thread, and then I will give them their own unique threads for discussion. Conversation moving slow? Go ahead and open your own thread in the next numeric order.</h2>
<table>
</table>
<h2>2️⃣ D.O integration updates:Project page integrations are largely done by this point, items that pointed to the bespoke tools now point to GitLabUser page integrations will be next on that list. </h2>
<table>
</table>
<h2>3️⃣ GitLabCI - @irinaz has been gathering up the examples from each of you who have tested out the GitLabCI system so far. We're compiling those together to inform defaults.@mixologic is currently working on a d7 core security test yml file as a way of working several problems paces into a key example.</h2>
<table>
</table>
<h2>4️⃣ Running pipelines on MR</h2>
<table>
<tr>
<td>irinaz</td>
<td>@mixologic @saschaeggi, I will summarize discussion about triggering pipelines on MR from forks/d.o issues, and post for your review later this week.@moshe what is your perspective on using this rule in drupalspoons? rules:<br>
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>We would need to add that to all jobs, otherwise the config won’t work for MRs (edited)</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>See <a href="https://docs.gitlab.com/ee/ci/pipelines/merge_request_pipelines.html#prerequisites">https://docs.gitlab.com/ee/ci/pipelines/merge_request_pipelines.html#prerequisites</a></td>
</tr>
<tr>
<td>saschaeggi</td>
<td>Easiest is to addworkflow:<br>
rules:<br>
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'this would make all defined jobs available for MRs</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>Got it working with this here: <a href="https://git.drupalcode.org/project/gin/-/merge_requests/123">https://git.drupalcode.org/project/gin/-/merge_requests/123</a></td>
</tr>
<tr>
<td>saschaeggi</td>
<td>so just looks like this right nowinclude:<br>
# This remote project centralize our CI "golden path" <a href="https://docs.gitlab.com/ee/ci/yaml/#includefile">https://docs.gitlab.com/ee/ci/yaml/#includefile</a><br>
remote: '<a href="https://gitlab.com/drupalspoons/composer-plugin/-/raw/master/templates/.gitlab-ci.yml">https://gitlab.com/drupalspoons/composer-plugin/-/raw/master/templates/.gitlab-ci.yml</a>'
<p># Needed to enable pipeline in MRs<br>
workflow:<br>
rules:<br>
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'see <a href="https://git.drupalcode.org/project/gin/-/blob/71816de997d0d4305fee18757e2c75623c988805/.gitlab-ci.yml@moshe">https://git.drupalcode.org/project/gin/-/blob/71816de997d0d4305fee18757e2c75623c988805/.gitlab-ci.yml@moshe</a> we just need to add# Needed to enable pipelines in MRs<br>
workflow:<br>
rules:<br>
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'to your drupalspoons config (edited)</p></td>
</tr>
<tr>
<td>irinaz</td>
<td>I love this as a demo of extending default gitlab-ci.yml, maybe for BoF at DrupalCon?</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>@irinaz the working example would be this MR: <a href="https://git.drupalcode.org/project/gin/-/merge_requests/123">https://git.drupalcode.org/project/gin/-/merge_requests/123</a></td>
</tr>
<tr>
<td>moshe</td>
<td>Great work finding this. I wonder why the existing config works well for Drupalspoons+DrupalForks MRs but apparently not on drupalcode. Anyway, have a look at the 2 templates at <a href="https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates/Workflows">https://gitlab.com/gitlab-org/gitlab/-/tree/master/lib/gitlab/ci/templates/Workflows</a>. We currently include Branch-PIpelines (<a href="https://gitlab.com/drupalspoons/composer-plugin/-/blob/master/templates/.gitlab-ci.yml#L1-3">https://gitlab.com/drupalspoons/composer-plugin/-/blob/master/templates/.gitlab-ci.yml#L1-3</a>) but I think you are proposing to use MergeRequest-Pipelines instead. Would that work for you?</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>@moshe to use MergeRequest-Pipelines instead. Would that work for you?Not necessary instead. But also on MRs. Yes.</td>
</tr>
<tr>
<td>moshe</td>
<td>Lets first try with "instead" ... I made a feature branch that has this change <a href="https://gitlab.com/drupalspoons/composer-plugin/-/merge_requests/47">https://gitlab.com/drupalspoons/composer-plugin/-/merge_requests/47</a>. Can you please temporarily edit your MR to use this feature branch? You will want to use this URL in your gitlab-ci file <a href="https://gitlab.com/drupalspoons/composer-plugin/-/raw/workflow-template/templates/.gitlab-ci.yml">https://gitlab.com/drupalspoons/composer-plugin/-/raw/workflow-template/templates/.gitlab-ci.yml</a></td>
</tr>
<tr>
<td>moshe</td>
<td>Folks can use Draft MRs to get tests running and work towards green. Then they remove Draft to communicate that its ready for review. One benefit of this approach is that it conserves CI build minutes (the alternative is to run pipelines before an MR is opened as per the top example at <a href="https://docs.gitlab.com/ee/ci/yaml/workflow.html#switch-between-branch-pipelines-and-merge-request-pipelines">https://docs.gitlab.com/ee/ci/yaml/workflow.html#switch-between-branch-pipelines-and-merge-request-pipelines</a>)</td>
</tr>
<tr>
<td>moshe</td>
<td>@saschaeggi I tested with Devel and the MR workflow works well. So I merged the change to composer-plugin. You can now remove your extra line <a href="https://git.drupalcode.org/project/gin/-/merge_requests/123/diffs#587d266bb27a4dc3022bbed44dfa19849df3044c_13_7">https://git.drupalcode.org/project/gin/-/merge_requests/123/diffs#587d266bb27a4dc3022bbed44dfa19849df3044c_13_7</a></td>
</tr>
<tr>
<td>saschaeggi</td>
<td>@moshe nice! I think it makes more sense to run them on the MR level anyway</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>@moshe seems to work, pipeline is running: <a href="https://git.drupalcode.org/project/gin/-/merge_requests/123">https://git.drupalcode.org/project/gin/-/merge_requests/123</a></td>
</tr>
<tr>
<td>mixologic</td>
<td>did you have to manually start that one?</td>
</tr>
<tr>
<td>mixologic</td>
<td>or do issue forks kick them off?</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>the pipelines automatically runs when a commit gets pushed to this open MR</td>
</tr>
<tr>
<td>saschaeggi</td>
<td>but for new MRs, I don’t know yet, further testing would be needed</td>
</tr>
</table>
<h2>Have to share this, sorry :wink:<a href="https://twitter.com/saschaeggi/status/1511783490219610113">https://twitter.com/saschaeggi/status/1511783490219610113</a></h2>
<table>
</table>
<p>Participants:</p>
<p>irinaz, saschaeggi, moshe, Mixologic</p>
issue