>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3327013. --> Reported by: [samitk](https://www.drupal.org/user/961934) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Getting following error/warnings</p> <p>FILE: /app/modules/contrib/iframe/README.md<br> ----------------------------------------------------------------------<br> FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES<br> ----------------------------------------------------------------------<br> 71 | WARNING | Line exceeds 80 characters; contains 83 characters<br> 72 | WARNING | Line exceeds 80 characters; contains 81 characters<br> ----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/iframe.install<br> -----------------------------------------------------------------------------------<br> FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES<br> -----------------------------------------------------------------------------------<br> 8 | WARNING | [x] Unused use statement<br> 51 | ERROR | [x] Doc comment short description must start with a capital letter<br> 51 | ERROR | [x] Doc comment short description must end with a full stop<br> 58 | ERROR | [x] Doc comment short description must start with a capital letter<br> 58 | ERROR | [x] Doc comment short description must end with a full stop<br> 67 | ERROR | [x] Expected 1 newline at end of file; 2 found<br> -----------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -----------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/iframe.module<br> ---------------------------------------------------------------------------------------------<br> FOUND 6 ERRORS AFFECTING 5 LINES<br> ---------------------------------------------------------------------------------------------<br> 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4<br> 23 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8<br> 23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"<br> 24 | ERROR | [x] Expected newline after closing brace<br> 25 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8<br> 37 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 2<br> ---------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Feeds/Target/Iframe.php<br> ----------------------------------------------------------------------<br> FOUND 1 ERROR AFFECTING 1 LINE<br> ----------------------------------------------------------------------<br> 33 | ERROR | [x] Whitespace found at end of line<br> ----------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/FieldTypeUpdateUtil.php<br> ----------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 60 ERRORS AND 12 WARNINGS AFFECTING 56 LINES<br> ----------------------------------------------------------------------------------------------------------------------------------------<br> 5 | WARNING | [x] Unused use statement<br> 5 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements<br> 6 | WARNING | [x] Unused use statement<br> 8 | ERROR | [x] Missing class doc comment<br> 15 | ERROR | [ ] Missing parameter type<br> 15 | ERROR | [x] Parameter comment must be on the next line<br> 16 | ERROR | [ ] Parameter comment must start with a capital letter<br> 16 | ERROR | [x] Parameter comment must be on the next line<br> 18 | ERROR | [ ] Public method name "FieldTypeUpdateUtil::_field_type_schema_column_add_helper" is not in lowerCamel format<br> 18 | ERROR | [x] Short array syntax must be used to define arrays<br> 23 | ERROR | [x] Whitespace found at end of line<br> 31 | ERROR | [x] Whitespace found at end of line<br> 34 | ERROR | [x] Whitespace found at end of line<br> 36 | ERROR | [ ] Comment indentation error, expected only 1 spaces<br> 37 | ERROR | [ ] Comment indentation error, expected only 4 spaces<br> 38 | WARNING | [x] There must be no blank line following an inline comment<br> 38 | WARNING | [ ] There must be no blank line following an inline comment<br> 38 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 39 | ERROR | [x] Whitespace found at end of line<br> 42 | ERROR | [x] Data types in @var tags need to be fully namespaced<br> 50 | ERROR | [x] Expected newline after closing brace<br> 68 | ERROR | [x] Whitespace found at end of line<br> 77 | ERROR | [x] Whitespace found at end of line<br> 83 | ERROR | [x] Whitespace found at end of line<br> 94 | ERROR | [x] Whitespace found at end of line<br> 109 | ERROR | [x] Whitespace found at end of line<br> 111 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters<br> 111 | ERROR | [x] Doc comment short description must end with a full stop<br> 113 | ERROR | [ ] Missing parameter type<br> 113 | ERROR | [x] Parameter comment must be on the next line<br> 114 | ERROR | [ ] Missing parameter comment<br> 114 | ERROR | [ ] Doc comment for parameter $column does not match actual variable name $field_type<br> 116 | ERROR | [ ] Public method name "FieldTypeUpdateUtil::_field_type_schema_column_spec_change_helper" is not in lowerCamel format<br> 117 | WARNING | [ ] Unused variable $processed_fields.<br> 120 | WARNING | [ ] Unused variable $field_item_class.<br> 121 | ERROR | [x] Whitespace found at end of line<br> 127 | WARNING | [ ] Unused variable $entity_storage_schema_sql.<br> 128 | WARNING | [ ] Unused variable $entity_definitions_installed.<br> 129 | ERROR | [x] Whitespace found at end of line<br> 134 | ERROR | [x] Data types in @var tags need to be fully namespaced<br> 144 | ERROR | [x] Expected newline after closing brace<br> 161 | ERROR | [x] Whitespace found at end of line<br> 190 | ERROR | [x] Whitespace found at end of line<br> 194 | ERROR | [x] Whitespace found at end of line<br> 197 | ERROR | [x] Whitespace found at end of line<br> 197 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines<br> 198 | ERROR | [x] Whitespace found at end of line<br> 209 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"<br> 224 | ERROR | [x] Whitespace found at end of line<br> 228 | ERROR | [ ] Missing parameter type<br> 228 | ERROR | [x] Parameter comment must be on the next line<br> 229 | ERROR | [ ] Parameter comment must start with a capital letter<br> 229 | ERROR | [x] Parameter comment must be on the next line<br> 229 | ERROR | [x] Parameter comment must end with a full stop<br> 231 | ERROR | [ ] Public method name "FieldTypeUpdateUtil::_field_type_schema_column_remove_helper" is not in lowerCamel format<br> 231 | ERROR | [x] Short array syntax must be used to define arrays<br> 236 | ERROR | [x] Whitespace found at end of line<br> 244 | ERROR | [x] Whitespace found at end of line<br> 247 | ERROR | [x] Whitespace found at end of line<br> 249 | ERROR | [ ] Comment indentation error, expected only 1 spaces<br> 250 | ERROR | [ ] Comment indentation error, expected only 4 spaces<br> 251 | WARNING | [x] There must be no blank line following an inline comment<br> 251 | WARNING | [ ] There must be no blank line following an inline comment<br> 251 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 252 | ERROR | [x] Whitespace found at end of line<br> 255 | ERROR | [x] Data types in @var tags need to be fully namespaced<br> 263 | ERROR | [x] Expected newline after closing brace<br> 281 | ERROR | [x] Whitespace found at end of line<br> 289 | WARNING | [ ] Unused variable $spec.<br> 290 | ERROR | [x] Whitespace found at end of line<br> 296 | ERROR | [x] Whitespace found at end of line<br> 305 | ERROR | [x] Whitespace found at end of line<br> ----------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 50 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldFormatter/IframeAsurlFormatter.php<br> ---------------------------------------------------------------------------------------------------------------------<br> FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br> ---------------------------------------------------------------------------------------------------------------------<br> 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 30 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"<br> ---------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldFormatter/IframeAsurlwithuriFormatter.php<br> ---------------------------------------------------------------------------------------------------------------------<br> FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES<br> ---------------------------------------------------------------------------------------------------------------------<br> 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 30 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"<br> ---------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ---------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldFormatter/IframeDefaultFormatter.php<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 15 ERRORS AND 1 WARNING AFFECTING 14 LINES<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> 20 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 47 | ERROR | [x] Inline comments must start with a capital letter<br> 47 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 49 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 51 | ERROR | [x] No space found before comment text; expected "// \iframe_debug(3, __METHOD__, $settings);" but found "//\iframe_debug(3, __METHOD__, $settings);"<br> 52 | ERROR | [x] No space found before comment text; expected "// \iframe_debug(3, __METHOD__, $field_settings);" but found "//\iframe_debug(3, __METHOD__,<br> | | $field_settings);"<br> 53 | ERROR | [x] No space found before comment text; expected "// \iframe_debug(3, __METHOD__, $items-&gt;getValue());" but found "//\iframe_debug(3, __METHOD__,<br> | | $items-&gt;getValue());"<br> 54 | ERROR | [x] There should be no white space after an opening "["<br> 54 | ERROR | [x] There should be no white space before a closing "]"<br> 62 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found<br> 115 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"<br> 132 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead<br> 134 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found<br> 184 | ERROR | [x] Expected newline after closing brace<br> 189 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 190 | ERROR | [x] The closing brace for the class must have an empty line before it<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldFormatter/IframeOnlyFormatter.php<br> ------------------------------------------------------------------------------------------------------------------------------<br> FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 8 LINES<br> ------------------------------------------------------------------------------------------------------------------------------<br> 6 | WARNING | [x] Unused use statement<br> 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 24 | ERROR | [x] Inline comments must start with a capital letter<br> 24 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 26 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 29 | ERROR | [x] There should be no white space after an opening "["<br> 29 | ERROR | [x] There should be no white space before a closing "]"<br> 37 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found<br> 43 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters<br> 44 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> ------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldType/IframeItem.php<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> 47 | ERROR | [x] Inline comments must start with a capital letter<br> 47 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 266 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this-&gt;t() instead<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldWidget/IframeUrlheightWidget.php<br> -----------------------------------------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br> -----------------------------------------------------------------------------------------------------------------<br> 16 | WARNING | The class short comment should describe what the class does and not simply repeat the class name<br> -----------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldWidget/IframeUrlwidthheightWidget.php<br> ---------------------------------------------------------------------------------------------<br> FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br> ---------------------------------------------------------------------------------------------<br> 23 | WARNING | Unused variable $on_admin_page.<br> ---------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/Field/FieldWidget/IframeWidgetBase.php<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 32 ERRORS AND 17 WARNINGS AFFECTING 41 LINES<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> 34 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 35 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 36 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 37 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 38 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 39 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 40 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 41 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 42 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 43 | ERROR | [x] Array indentation error, expected 6 spaces but found 8<br> 63 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters<br> 64 | WARNING | [x] There must be no blank line following an inline comment<br> 64 | WARNING | [ ] There must be no blank line following an inline comment<br> 67 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found<br> 79 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters<br> 79 | ERROR | [x] Inline comments must start with a capital letter<br> 79 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 128 | ERROR | [ ] The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines<br> 168 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 181 | WARNING | [x] There must be no blank line following an inline comment<br> 181 | WARNING | [ ] There must be no blank line following an inline comment<br> 184 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found<br> 217 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters<br> 219 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters<br> 219 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 223 | WARNING | [ ] There must be no blank line following an inline comment<br> 231 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters<br> 238 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found<br> 301 | ERROR | [x] Use null coalesce operator instead of ternary operator.<br> 311 | ERROR | [x] Use null coalesce operator instead of ternary operator.<br> 321 | ERROR | [x] Use null coalesce operator instead of ternary operator.<br> 347 | ERROR | [x] Inline comments must start with a capital letter<br> 347 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 348 | WARNING | [ ] Unused variable $settings.<br> 365 | ERROR | [x] Inline comments must start with a capital letter<br> 365 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 366 | WARNING | [ ] Unused variable $settings.<br> 383 | ERROR | [x] Inline comments must start with a capital letter<br> 383 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses<br> 393 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 394 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead<br> 397 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"<br> 401 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"<br> 404 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this-&gt;t() instead<br> 407 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this-&gt;t() instead<br> 421 | ERROR | [ ] Description for the @return value is missing<br> 423 | ERROR | [ ] Type hint "array" missing for $form<br> 432 | ERROR | [x] Expected 1 space after FOR keyword; 0 found<br> 476 | ERROR | [ ] The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines<br> ----------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ----------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/migrate/field/IframeField.php<br> ------------------------------------------------------------------------------------------------------------------------<br> FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES<br> ------------------------------------------------------------------------------------------------------------------------<br> 7 | WARNING | [x] Unused use statement<br> 11 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph<br> 48 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 49 | ERROR | [x] The closing brace for the class must have an empty line before it<br> ------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> ------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/migrate/process/d6/CckIframe.php<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES<br> ---------------------------------------------------------------------------------------------------------------------------------------------<br> 18 | WARNING | The class short comment should describe what the class does and not simply repeat the class name<br> 45 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.<br> 49 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.<br> ---------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/src/Plugin/migrate/process/d7/CckIframe.php<br> -------------------------------------------------------------------------------------------------------------------------------------------------<br> FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES<br> -------------------------------------------------------------------------------------------------------------------------------------------------<br> 18 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name<br> 45 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.<br> 49 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.<br> 70 | ERROR | [x] Expected 1 blank line after function; 0 found<br> 71 | ERROR | [x] The closing brace for the class must have an empty line before it<br> -------------------------------------------------------------------------------------------------------------------------------------------------<br> PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY<br> -------------------------------------------------------------------------------------------------------------------------------------------------</p> <p>FILE: /app/modules/contrib/iframe/tests/src/Kernel/IframeSchemaTest.php<br> -----------------------------------------------------------------------<br> FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE<br> -----------------------------------------------------------------------<br> 60 | WARNING | Unused variable $entity_storage.<br> -----------------------------------------------------------------------</p> <p>Time: 18.69 secs; Memory: 14MB</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Run following command</p> <p>phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/iframe/</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Above error/warnings need to be fixed</p>