Issue #3266906: Fix coding standard issues for 3.x (975549ae) · Commits · project / homebox

css/homebox.css

+26 −8

Changes for css/homebox.css: 26 added lines, 8 removed lines.
Original line number	Diff line number	Diff line
		@@ -6,13 +6,16 @@
		#homebox-page .homebox-save-form {
		display: none;
		}

		#homebox {
		position: relative;
		}


		/**
		* Columns/regions
		* Columns/regions:
		*/

		.homebox-column {
		/margin: 2px;/
		min-height: 40px;
		@@ -21,53 +24,68 @@
		width: 100%;
		}


		/**
		* Portlets/boxes
		* Portlets/boxes:
		*/

		#homebox .homebox-portlet {
		margin: 2px 0 5px;
		padding: 0;
		border: 3px solid #eee;
		background-color: white;
		}

		#homebox .homebox-portlet .homebox-portlet-inner {
		border: 1px solid #c0c0c0;
		overflow: hidden;
		}

		#homebox .portlet-content {
		padding: 4px;
		}

		#homebox .homebox-portlet .portlet-header {
		margin: 0;
		padding: 2px 4px;
		border-bottom: 1px solid #ddd;
		background: #e4f0f8; /* matches garland */
		background: #e4f0f8;
		/* matches garland */
		color: #494949;
		min-height: 18px;
		font-size: 1em;
		}

		#homebox .homebox-draggable .portlet-header:hover {
		cursor: move;
		}

		#homebox .homebox-portlet .portlet-header .portlet-title {
		display: block;
		z-index: 9; /* IE is terrible */
		position: relative; /* IE is terrible */
		z-index: 9;
		/* IE is terrible */
		position: relative;
		/* IE is terrible */
		width: 75%;
		float: left;
		}


		/**
		* Icons
		* Icons:
		*/

		.portlet-icon {
		float: right;
		height: 16px;
		width: 16px;
		cursor: pointer;
		z-index: 10; /* IE is terrible */
		position: relative; /* IE is terrible */
		z-index: 10;
		/* IE is terrible */
		position: relative;
		/* IE is terrible */
		}

		.portlet-close {
		background: url(../images/close.gif);
		text-indent: -9999px;

+4 −6

Changes for homebox.install: 4 added lines, 6 removed lines.
Original line number	Diff line number	Diff line
		<?php

		use Drupal\Core\Field\BaseFieldDefinition;
		use Drupal\field\Entity\FieldConfig;
		use Drupal\field\Entity\FieldStorageConfig;

		/**
		* @file
		* Update scripts for the Homebox module.
		* @file Update scripts for the Homebox module.
		*/

		/**
		* Implementations of hook_update_N().
		*
		* Enable the new jQuery UI modules.
		*/
		function homebox_update_8100() {
		@@ -33,6 +28,7 @@ function homebox_update_8101() {

		// 2. Enable customPageEnabled, so we can map the path:
		$homebox->set('dashboardPageEnabled', TRUE);

		// 2. Changed "$homebox->path" to "$homebox->customPagePath":
		$homebox->set('customPagePath', '/' . ltrim($homebox->get('path'), '/'));

		@@ -42,7 +38,9 @@ function homebox_update_8101() {
		// Remove "$homebox->options" (without replacement):
		// No action needed. Save with new schema does the deletions for us.

		// Save changed configuraiton:
		$homebox->save();

		\Drupal::service('router.builder')->setRebuildNeeded();
		}

+1 −0

Changes for src/Access/HomeboxAddAccessCheck.php: 1 added line, 0 removed lines.
Original line number	Diff line number	Diff line
		@@ -41,6 +41,7 @@ class HomeboxAddAccessCheck implements AccessInterface {
		* (optional) The homebox.
		*
		* @return bool\|\Drupal\Core\Access\AccessResultAllowed\|\Drupal\Core\Access\AccessResultInterface\|\Drupal\Core\Access\AccessResultNeutral
		* The access result.
		*/
		public function access(AccountInterface $account, HomeboxInterface $homebox = NULL) {
		$access_control_handler = $this->entityManager->getAccessControlHandler('homebox_layout');

+2 −1

Changes for src/Controller/HomeboxController.php: 2 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -8,7 +8,7 @@ use Drupal\Core\Controller\ControllerBase;
		use Drupal\homebox\Entity\HomeboxInterface;

		/**
		* Class HomeboxController.
		* The Homebox controller.
		*
		* @package homebox\Controller
		*/
		@@ -119,4 +119,5 @@ class HomeboxController extends ControllerBase {
		public function pageTitle(HomeboxInterface $homebox) {
		return $homebox->label();
		}

		}

+4 −1

Changes for src/Controller/HomeboxLayoutController.php: 4 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -157,7 +157,10 @@ class HomeboxLayoutController extends ControllerBase implements ContainerInjecti
		public function revisionPageTitle($homebox_layout_revision) {
		/** @var \Drupal\homebox\Entity\HomeboxLayoutInterface $homebox_layout */
		$homebox_layout = $this->entityTypeManager()->getStorage('homebox_layout')->loadRevision($homebox_layout_revision);
		return $this->t('Revision of %title from %date', ['%title' => $homebox_layout->label(), '%date' => $this->dateFormatter->format($homebox_layout->getRevisionCreationTime())]);
		return $this->t('Revision of %title from %date', [
		'%title' => $homebox_layout->label(),
		'%date' => $this->dateFormatter->format($homebox_layout->getRevisionCreationTime())
		]);
		}

		/**