>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3602639. --> Reported by: [pfrenssen](https://www.drupal.org/user/382067) Related to !94 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Splitting the <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/graphql_webform/-/work_items/3595219" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/graphql_webform/-/work_items/3595219</a></span> proof-of-concept into nine standalone issues landed every feature on <code>3.x</code>, but three pieces of test coverage from the PoC were not carried over. The features work; they are simply unverified, so a future regression in any of them would pass CI silently.</p> <p>The gaps:</p> <ul> <li><strong>Term select without a depth argument.</strong> <code>WebformElementWebformTermSelect.options</code> takes an optional <code>depth</code> argument (kept additive in <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/graphql_webform/-/work_items/3598973" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/graphql_webform/-/work_items/3598973</a></span>). <code>tests/src/Kernel/Element/TermSelectTest.php</code> only ever queries <code>options(depth: ...)</code>, so the path where <code>depth</code> is omitted is untested.</li> <li><strong>Per-element time-token cacheability.</strong> A <code>[date:*]</code> token in an element property such as <code>#description</code> bubbles <code>max-age=0</code>, which the element resolver must surface on the response (foundation landed in <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/graphql_webform/-/work_items/3598935" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/graphql_webform/-/work_items/3598935</a></span>). <code>tests/src/Kernel/Element/DefaultValueTokenCacheabilityTest.php</code> and <code>tests/src/Kernel/Element/TokenPrefillCacheabilityTest.php</code> cover default-value and prefill tokens, but not a time token in an arbitrary visible element property.</li> <li><strong>Empty-string submissions across element types.</strong> A frontend submits <code>''</code> when a user clears a field, and the mutation must accept that as "no value" rather than erroring. The datelist fix landed in <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/graphql_webform/-/work_items/3599000" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/graphql_webform/-/work_items/3599000</a></span> and <code>tests/src/Kernel/Mutation/FormSubmissionDatelistTest.php</code> covers datelist, but there is no test asserting clean acceptance of <code>''</code> across the broader set of element types.</li> </ul> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Add the three missing test cases against the existing exported fixtures, in one change. No production code change is expected.</p> <ul> <li>Term select: extend <code>TermSelectTest</code> (or add a query mirroring <code>tests/queries/term_select.gql</code> with <code>depth</code> dropped) to assert <code>options</code> resolves to the full term list when <code>depth</code> is omitted, and that the per-term plus <code>taxonomy_term_list</code> cache tags are emitted.</li> <li>Time-token cacheability: add a kernel test that puts a <code>[date:*]</code> token in a textfield <code>#description</code> and asserts the GraphQL response carries <code>max-age=0</code>. Reuse or extend <code>tests/modules/graphql_webform_test/config/install/webform.webform.graphql_webform_test_date_token.yml</code>.</li> <li>Empty string: add a mutation test extending <code>tests/src/Kernel/Mutation/FormSubmissionTestBase.php</code> that submits <code>''</code> to a representative element of each family and asserts the submission saves with an empty value and no error.</li> </ul> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <ul> <li>Write the three tests.</li> <li>Confirm no production change is needed; if any test surfaces a real defect, split that fix into its own issue under <span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/graphql_webform/-/work_items/3595219" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/graphql_webform/-/work_items/3595219</a></span>.</li> <li>Run phpunit, phpcs and phpstan.</li> </ul>