Commit eafb07d3 authored by Joshua Sedler's avatar Joshua Sedler 🤸🏼 Committed by Jakob P
Browse files

Issue #3300716 by Grevil, beunerd, Michelle, japerry: Deprecated function:... 

Issue #3300716 by Grevil, beunerd, Michelle, japerry: Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated
parent dc503184

src/EventSubscriber/GoogleAnalyticsConfig/DefaultConfig.php

+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ class DefaultConfig implements EventSubscriberInterface { 
    // Per RFC 2109, cookie domains must contain at least one dot other than the

    // first. For hosts such as 'localhost' or IP Addresses we don't set a

    // cookie domain.

    if ($domain_mode == 1 && count(explode('.', $cookie_domain)) > 2 && !is_numeric(str_replace('.', '', $cookie_domain))) {

    if (!empty($cookie_domain) && $domain_mode == 1 && count(explode('.', $cookie_domain)) > 2 && !is_numeric(str_replace('.', '', $cookie_domain))) {

      $arguments = array_merge($arguments, ['cookie_domain' => $cookie_domain]);

      $javascript->setAdsenseScript($cookie_domain);

    }

src/Form/GoogleAnalyticsAdminSettingsForm.php

+1 −1
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ class GoogleAnalyticsAdminSettingsForm extends ConfigFormBase { 
    global $cookie_domain;

    $multiple_sub_domains = [];

    foreach (['www', 'app', 'shop'] as $subdomain) {

      if (count(explode('.', $cookie_domain)) > 2 && !is_numeric(str_replace('.', '', $cookie_domain))) {

      if (!empty($cookie_domain) && count(explode('.', $cookie_domain)) > 2 && !is_numeric(str_replace('.', '', $cookie_domain))) {

        $multiple_sub_domains[] = $subdomain . $cookie_domain;

      }

      // IP addresses or localhost.