Remove possible wrapping quotes from PROJECT_TYPE.
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3521933. --> Reported by: [kristiaanvandeneynde](https://www.drupal.org/user/1345130) Related to !351 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p><span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/gitlab_templates/issues/3506040" title="Status: Closed (fixed)">#3506040: Create new variable DRUPAL_PROJECTS_PATH and use it to remove hardcoded "/custom" paths</a></span> introduced the following lines:</p> <pre># If DRUPAL_PROJECTS_PATH has not been defined (via UI form or in custom .gitlab-ci.yml) then set to the default.<br>&nbsp;&nbsp;&nbsp; [[ $DRUPAL_PROJECTS_PATH == "" ]] &amp;&amp; export DRUPAL_PROJECTS_PATH="sites/all/${PROJECT_TYPE}s/custom" &amp;&amp; echo "DRUPAL_PROJECTS_PATH=$DRUPAL_PROJECTS_PATH" &gt;&gt; build.env</pre><p>In the logs of <a href="https://git.drupalcode.org/project/group/-/pipelines/485531">a weirdly failing test</a> (it can't find a class that is there), I see this as such:</p> <pre>sudo -u www-data -H -E vendor/bin/phpunit&nbsp; --bootstrap /builds/project/group/web/core/tests/bootstrap.php /builds/project/group/web/'module's/custom/group --log-junit /builds/project/group/junit.xml&nbsp; </pre><p>Note the broken path <code>builds/project/group/web/'module's/custom/group</code></p> <p>This is because Group specifies it's type in the info.yml file with single quotes, which is valid Yaml, and the script runs the following:</p> <pre>elif [[ $PROJECT_TYPE == "" ]]; then<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; # If we have a project name, and project type has not been pre-defined, then read the corresponding .info.yml to get it.<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; INFO_YML=$(find . -name "$PROJECT_NAME.info.yml" | head -1)<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; export PROJECT_TYPE=$(sed -n -e 's/^[[:space:]]*type:[[:space:]]*//p' $INFO_YML | head -1 | tr '[:upper:]' '[:lower:]')</pre><p>I've pushed a hotfix to the branch that manually sets PROJECT_TYPE to see if this fixes things, but I wanted to raise the bug report nonetheless as it doesn't seem right to have paths with single quotes in them.</p> <h4 id="summary-steps-reproduce">Steps to reproduce</h4> <p>Specify a project type in an info.yml file using single quotes, see GitLab CI use the quotes in paths.</p> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>Take the possibility of quotes into account or otherwise sanitize the value from the info file.</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <h3 id="summary-ui-changes">User interface changes</h3> <h3 id="summary-api-changes">API changes</h3> <h3 id="summary-data-model-changes">Data model changes</h3>
issue