>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3426292. --> Reported by: [fjgarlin](https://www.drupal.org/user/2495842) Related to !180 >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>Variables that contain open-ended tweaks for jobs and that are likely to be changed by maintainers should start with _ (underscore).</p> <p>From <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-7"><a href="https://www.drupal.org/project/gitlab_templates/issues/3343522" title="Status: Closed (fixed)">#3343522: Hide variables that should not be overridden</a></span>, we have:</p> <blockquote><p> In the variables file: <a href="https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.variables.yml?ref_type=heads">https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.variables.yml?ref_type=heads</a><br> We have:<br> - First group which starts with underscore for probably the most common tweaks for the jobs like Drupal version, php version, database type...<br> - Then the SKIP_ ones, which are switches (on/off)<br> - Then the OPT_IN_ ones, which are switches (on/off)<br> - Then LENIENT_ALLOW_LIST and COMPOSER_PATCHES_FILE which should probably start with _ (as it is configuration for the composer jobs) but don't <strong>&lt;=== I only see an inconsistency in here.</strong></p> <p>Then a whole bunch of variables that we don't want changes to:<br> - _CONFIG_DOCKERHUB_ROOT<br> - CORE_ variables<br> - Database related variables<br> - Some constraints </p> <p>And finally, variables to test downstream and merge requests or fixed tags.</p> <p>So at this point, I only think we have a couple of variables that don't follow the pattern. We could do a deprecation job for them or just live with them as they are. </p></blockquote> <h3 id="summary-proposed-resolution">Proposed resolution</h3> <p>We can reuse the <code>.pre</code> job we had for <code>SKIP_COMPOSER</code> and add the patches+lenient variables there (through the child issue).</p> <h3 id="summary-remaining-tasks">Remaining tasks</h3> <p>MR and also do a gitlab search of usage of these variables to let the maintainers know about it.<br> <a href="https://git.drupalcode.org/search?group_id=2&amp;repository_ref=main&amp;scope=blobs&amp;search=LENIENT_ALLOW_LIST">Lenient search</a>.<br> <a href="https://git.drupalcode.org/search?group_id=2&amp;repository_ref=main&amp;scope=blobs&amp;search=COMPOSER_PATCHES_FILE">Composer patches search</a>.</p> > Related issue: [Issue #3343522](https://www.drupal.org/node/3343522)