Improvements in log output, consistency in syntax, alignment with D7
Problem/Motivation
This issue gathers together several changes to the main.yml and main-d7.yml file that should not affect the functioning of any jobs. They relate to presentation of log output, syntax, organisation within the files and forgotten alignment/backports to the D7 template. There are five proposed changes.
Proposed Changes
- Wrap
composer installand*require-drushinto a collapsed section. This is a big part of the log, but very often we have to scroll over to find the details we are looking for. Having it in a collapsed section makes the log more easily navigable. - Remove the deletion of 'parallel' in test-only changes for D7. This was done for D10, but forgotten and not backported to main-d7.yml.
- The jobs in the file are generally grouped by their stage, we have all the build jobs, then the validate jobs then the test jobs. 'upgrade status' is a test job, it extends 'testing-job-base', but is placed in the middle of the validation jobs. This needs to be moved in the file.
- Consistency in 'extends:' and 'needs:' syntax. There are 38 "extends:" in the main file which have the full value on the same on same line, which helps when seaching a file to highlight every 'extends:' as you can see what element it extends. There are just 5 which have the syntax split over two lines, which means your editor's 'find all' does not show what the job is extending. Similarly for the "needs:" syntax, some are on one line, some are split over two lines.
-
.check-composer-end-codedoes not need to print the exit code when all is ok and the code is 0. Only print it when there is a problem.