[META] Gin 6.x: Preparation for merging into core
>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #3530849. --> Reported by: [pameeela](https://www.drupal.org/user/1431110) >>> <h3 id="summary-problem-motivation">Problem/Motivation</h3> <p>In preparation of merging Gin as the default admin theme into core (see <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-1"><a href="https://www.drupal.org/project/drupal/issues/3530852" title="Status: Active">#3530852: [META] Admin theme modernisation</a></span>), Gin needs to be prepared outside of code. This meta issue provides the overview of all related tasks that need to be completed.</p> <h3 id="proposed-solution">Proposed solution</h3> <p>Gin 5.x branch is in active use with Drupal 11.2, and to avoid unintended updates to this WIP by composer, the preparation will take place in the new 6.x branch. The prioritized steps are:</p> <ul> <li><strong>Must-have / blocking</strong> <ul> <li>Remove dependency on Claro <ul> <li>This affects libraries, CSS files, templates, and PHP code</li> <li>Include Claro base into Gin</li> </ul> </li> <li>Move contrib module integrations out of Gin, and file corresponding issues in the respective contrib projects</li> <li>A lot of code (PHP, JS, and some CSS) deals with too many different contexts, all of which can be removed once Gin only supports the latest version of Drupal</li> <li>Core merge regression tests<br><br> Write regression tests to make sure we get the same result after cleaning up and merging Gin into core.</li> </ul> </li> <li><strong>Should-have</strong> <ul> <li>Deduplicate Claro code <ul> <li>Gin inherits all of Claro, but also overrides a lot of it. This needs to be simplified.</li> </ul> </li> </ul> </li> <li><strong>Nice to have</strong> <ul> <li>Restructure CSS files into component-related files</li> <li>Build the library structure accordingly</li> <li>Clean-up Gin PHP <ul> <li>Optimize code</li> </ul> </li> </ul> </li> <li><strong>TBD</strong> <ul> <li>Add tests for PHP code (needs MVP defined) <ul> <li>Are there no tests at all for the PHP? Some? Discuss. The extent of current coverage will determine how much of this is "must-have" and how much is "should-have" or even "nice-to-have".</li> </ul> </li> <li>Clean-up Gin settings <ul> <li>Remove navigation types and toolbar</li> <li>Remove sticky action buttons</li> </ul> </li> <li>Get regression tests green</li> </ul> </li> </ul> <p><strong>Important notes for testing:</strong> Please turn off gin_toolbar in case you're using it. This is because it alters the libraries and adds some Claro related libraries, which is surprising that this even works, although Claro is not enabled.</p> > Related issue: [Issue #3520057](https://www.drupal.org/node/3520057) > Related issue: [Issue #3506302](https://www.drupal.org/node/3506302) > Related issue: [Issue #3556916](https://www.drupal.org/node/3556916) > Related issue: [Issue #3555041](https://www.drupal.org/node/3555041) > Related issue: [Issue #3533986](https://www.drupal.org/node/3533986) > Related issue: [Issue #3541805](https://www.drupal.org/node/3541805) > Related issue: [Issue #3564510](https://www.drupal.org/node/3564510) > Related issue: [Issue #3556948](https://www.drupal.org/node/3556948) > Related issue: [Issue #3530852](https://www.drupal.org/node/3530852)
issue