>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #210665. --> Reported by: [douggreen](https://www.drupal.org/user/29191) >>> <p><b>Task Description:</b></p> <p>Check that all of the listed modules below have .install files, that they have a hook_uninstall. and that the hook_uninstall deletes all tables and variables (using variable_del). It should delete any tables that are created in hook_install. And it should delete any variables that are created. Variables are usually created through the call to variable_set, but they can also be created through the settings forms (look for the function that defines system_settings_form).</p> <p>You don't need a local sandbox, but having one would be best. It's always best to run the code before submitting a patch. But since this is a fairly repetitive task, and in most cases you'll be creating a new .install file, the local sandbox isn't a "hard" requirement.</p> <p>A sample hook_uninstall, taken from phpass, is:</p> <pre>function phpass_uninstall() {<br>&nbsp; db_query("DROP TABLE {user_phpass}");<br>&nbsp; variable_del('user_hash_method');<br>&nbsp; variable_del('user_hash_strength');<br>&nbsp; variable_del('user_hash_portable');<br>}</pre><p>Before you start on any one module, you should check the modules issue queue to make sure that a patch hasn't been submitted. Please add a comment to this issue when you complete a module. I'll also try to check them off in the module description, as the issues are marked RTBC or Fixed.</p> <p>This is two GHOP tasks.</p> <p><b>Task 1:</b></p> <ol> <li><a href="https://www.drupal.org/project/civicrm_activeuser">CiviCRM Active User</a></li> <li><a href="https://www.drupal.org/project/civicrm_countblock">CiviCRM Count Block</a></li> <li><a href="https://www.drupal.org/project/civicrm_theme">CiviCRM Theme</a></li> <li><a href="https://www.drupal.org/project/coder">Coder</a></li> <li><a href="https://www.drupal.org/project/shortform">Short Form</a></li> </ol> <p><a href="https://www.drupal.org/project/coder">Coder</a> is the only big module in Task 1. You'll need to look at <code>_coder_settings_form()</code>. Three of the modules are related to <a href="http://civicrm.org">CiviCRM</a>. You don't absolutely need CiviCRM to complete this task, but learning about CiviCRM would be a good thing.</p> <p><b>Task 2</b>:</p> <ol> <li><a href="https://www.drupal.org/project/reindex">Reindex</a></li> <li><a href="https://www.drupal.org/project/retease">Retease</a></li> <li><a href="https://www.drupal.org/project/daterange">Views Date Range Filter</a></li> <li><a href="https://www.drupal.org/project/views_fastsearch">Views Fast Search</a></li> <li><a href="https://www.drupal.org/project/views_filterblock">Views Filter Block</a></li> <li><a href="https://www.drupal.org/project/tagadelic_views">Views Tagadelic</a></li> </ol> <p><a href="https://www.drupal.org/project/reindex">Reindex</a> is a 6.x module, so the patch should be against 6.x. All the other modules, except <a href="https://www.drupal.org/project/retease">Retease</a>, are related to the <a href="https://www.drupal.org/project/views">Views</a> module. You don't need to install Views to complete this task, but once again, learning about Views would be a good thing.</p> <p><b>Deliverables:</b></p> <ul> <li>create a Drupal issue against each module and submit a patch file for 5.x. If there is already a .install file, then be sure to submit the patch against the latest version on the DRUPAL-5 or DRUPAL-5--2 branches. You'll need to know how to create a patch file that adds a new file. The deliverable is not complete until the issue is reviewed and the status is set to either RTBC or Fixed (i.e., committed).</li> <li>If a module is up-to-date and doesn't need a patch file, add a comment to this issue, saying that you checked the module and that it doesn't need to be patched.</li> </ul> <p><b>Resources:</b></p> <ul> <li>api.drupal.org: <a href="http://api.drupal.org/api/function/hook_uninstall/5">hook_uninstall</a>, <a href="http://api.drupal.org/api/function/variable_del/5">variable_del</a>, <a href="http://api.drupal.org/api/function/system_settings_form/5">system_settings_form</a></li> <li><a href="http://drupal.org/patch">Patch files</a> and <a href="http://drupal.org/patch/create">Creating patches</a></li> <li><a href="http://code.google.com/p/google-highly-open-participation-drupal/wiki/FurtherInformation">General GHOP Resources</a></li> </ul> <p><b>Primary Contact:</b> <a href="https://www.drupal.org/user/29191">Doug Green</a></p>