Confusing behaviour when on/off toggle is disabled
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #3554639. -->
Reported by: [thamas](https://www.drupal.org/user/53339)
>>>
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>After installing Frontend Editing the "Enable on/off toggle in UI" is enabled at /admin/config/frontend-editing. The default state of the toggle is "OFF", and frontend editing is disabled until the toggle is set to "ON".</p>
<p>However, the "Enable on/off toggle in UI" can be disabled. In this case, an on/off toggle is displayed in the toolbar instead. Its default state is "OFF" as well. But while the toggle in the toolbar shows "OFF", the frontend editing functionality is enabled! </p>
<p>I think the state of any toggle button and the frontend editing functionality must be in sync. </p>
<h4 id="summary-steps-reproduce">Steps to reproduce</h4>
<ul>
<li>Enable frontend editing for eg. a content type.</li>
<li>Disable "Enable on/off toggle in UI"</li>
<li>See that another on/off toggle is displayed in the toolbar and its state is "OFF". See that while the button states "OFF", the frontend-editing functionality is ON/enabled.</li>
</ul>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>Keep the toggle button and the functionality in sync. </p>
<p>Preferably, set the default state of the functionality to " turned off", so the user has to turn it on to use it.</p>
<p>Alternatively, set the default state of the toggle button in the toolbar to "ON" (not recommended). </p>
<p>Because there is always a toggle button (either in the toolbar/or in the page)—and that is good!—consider renaming the setting at /admin/config/frontend-editing from "Enable on/off toggle in UI" to something like "Enable a positionable on/off toggle in the UI". (The description also should be updated accordingly.)</p>
<h3 id="summary-remaining-tasks">Remaining tasks</h3>
<p>Keep the toggle button and the functionality in sync. </p>
<h3 id="summary-ui-changes">User interface changes</h3>
<p>None in the frontend theme, description change on the admin config UI of the module.</p>
<h3 id="summary-api-changes">API changes</h3>
<p>–</p>
<h3 id="summary-data-model-changes">Data model changes</h3>
<p>–</p>
issue