Commit 9541646a authored by Harsh Panchal's avatar Harsh Panchal Committed by Ivan Rodriguez
Browse files

Issue #3296182 by Harsh panchal: phpcs --standard=Drupalpractice issue

parent 22c8d6de

composer.json

0 → 100644
+15 −0
Original line number Diff line number Diff line 
{

          "type": "package",

          "package": {

            "name": "fortawesome/font-awesome",

            "version": "5.3.1",

            "type": "drupal-library",

            "dist": {

              "url": "https://github.com/FortAwesome/Font-Awesome/archive/5.3.1.zip",

              "type": "zip"

            },

            "require": {

              "composer/installers": "^1.2.0"

            }

          }

}

js/jquery.barrating.js

deleted100644 → 0
+0 −596

File deleted.

Preview size limit exceeded, changes collapsed.

js/jquery.barrating.min.js

deleted100644 → 0
+0 −2

File deleted.

Preview size limit exceeded, changes collapsed.

src/Controller/RatingController.php

+29 −5
Original line number Diff line number Diff line
@@ -2,22 +2,46 @@ 


namespace Drupal\rating\Controller;



use Drupal\Core\Controller\ControllerBase;

use Drupal\rating\Utility\Utility;

use Drupal\Core\Controller\ControllerBase;

use Symfony\Component\HttpFoundation\RequestStack;

use Symfony\Component\HttpFoundation\JsonResponse;

use Symfony\Component\DependencyInjection\ContainerInterface;

use Drupal\Core\DependencyInjection\ContainerInjectionInterface;



/**

 * Processes rating input.

 */

class RatingController extends ControllerBase {

class RatingController extends ControllerBase implements ContainerInjectionInterface {



  /**

   * {@inheritdoc}

   */

  private $requestStack;



  /**

   * {@inheritdoc}

   */

  public function __construct(RequestStack $request_stack) {

    $this->requestStack = $request_stack;

  }



  /**

   * {@inheritdoc}

   */

  public static function create(ContainerInterface $container) {

    return new static(

      $container->get('request_stack')

    );

  }



  /**

   * Sets the rating value in the stars and the displayed text.

   */

  public function set() {

    $user = $_POST['uid'];

    $node = $_POST['nid'];

    $rating = $_POST['rating'];

    $user = $this->requestStack->getCurrentRequest()->request->get('uid');

    $node = $this->requestStack->getCurrentRequest()->request->get('nid');

    $rating = $this->requestStack->getCurrentRequest()->request->get('rating');

    Utility::setRating($user, $node, $rating);

    $numRating = Utility::getRating($node);

    $return_arr = ["numRating" => $numRating];

src/Form/RatingForm.php

+28 −5
Original line number Diff line number Diff line
@@ -3,14 +3,37 @@ 
namespace Drupal\rating\Form;



use Drupal\Core\Form\FormBase;

use Drupal\Core\Form\FormStateInterface;

use Drupal\rating\Utility\Utility;

use Drupal\Core\Form\FormStateInterface;

use Drupal\Core\Session\AccountInterface;

use Symfony\Component\DependencyInjection\ContainerInterface;



/**

 * {@inheritdoc}

 */

class RatingForm extends FormBase {



  /**

   * {@inheritdoc}

   */

  protected $account;



  /**

   * {@inheritdoc}

   */

  public function __construct(AccountInterface $account) {

    $this->account = $account;

  }



  /**

   * {@inheritdoc}

   */

  public static function create(ContainerInterface $container) {

    return new static(

      $container->get('current_user')

    );

  }



  /**

   * {@inheritdoc}

   */
@@ -22,13 +45,13 @@ class RatingForm extends FormBase { 
   * {@inheritdoc}

   */

  public function buildForm(array $form, FormStateInterface $form_state, $options = []) {

    $uid = \Drupal::currentUser()->id();

    $uid = $this->account->id();

    $nid = $options['rating_id'];

    $star_rating = Utility::getStarRating($uid, $nid);

    $rating = Utility::getRating($nid);

    $rating_text = $rating;

    if ($rating <= 0) {

      $rating = 'No ratings given.';

      $rating_text = 'No ratings given.';

    }

    $form['#attributes'] = [

      'class' => [$options['rating_size'], $options['rating_color']],
@@ -57,9 +80,9 @@ class RatingForm extends FormBase { 
        ],

      ],

    ];

    $numeric_rating = t('Rating : <span id="numeric_rating_@ratingId">@rating</span>', [

    $numeric_rating = $this->t('Rating : <span id="numeric_rating_@ratingId">@rating</span>', [

      '@ratingId' => $options['rating_id'],

      '@rating' => $rating,

      '@rating' => $rating_text,

    ]);

    $form['numeric_rating'] = [

      '#markup' => $numeric_rating,