Commit 0ff8fcbc authored by Urvashi Vora's avatar Urvashi Vora Committed by urvashi.v
Browse files

Issue #3287026: Coding Standard issues in first_time_login module

parent 682165f5

first_time_login.module

+4 −4
Changes for first_time_login.module: 4 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -104,20 +104,20 @@ function first_time_login_user_login($account) { 
      $last_updated_date = \Drupal::service('date.formatter')->format($updated_date, 'custom', 'd-M-Y');

      if ($needsupdate == FALSE) {

        $new_user_message = $config->get('first_time_login_new_user_message');

        \Drupal::messenger()->addMessage((t($new_user_message, [

        \Drupal::messenger()->addMessage($new_user_message, [

          '@user' => $account->getAccountName(),

          '@site_name' => $site_name,

          '@created_date' => $account_created,

        ]))

        ]

        );

      }

      elseif ($details->first_time_login == 0) {

        $update_user_message = $config->get('first_time_login_update_user_message');

        \Drupal::messenger()->addMessage((t($update_user_message, [

        \Drupal::messenger()->addMessage($update_user_message, [

          '@user' => $account->getAccountName(),

          '@site_name' => $site_name,

          '@updated_date' => $last_updated_date,

        ]))

        ]

        );

      }

      $response->send();

src/Form/FirstTimeLoginSettings.php

+19 −4
Changes for src/Form/FirstTimeLoginSettings.php: 19 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -4,9 +4,10 @@ namespace Drupal\first_time_login\Form; 


use Drupal\Core\Form\ConfigFormBase;

use Drupal\Core\Form\FormStateInterface;

use Drupal\Core\Config\ConfigFactory;



/**

 * Class FirstTimeLoginSettings.

 * Implements Class FirstTimeLoginSettings.

 *

 * @package Drupal\first_time_login\Form\FirstTimeLoginSettings

 */
@@ -21,6 +22,20 @@ class FirstTimeLoginSettings extends ConfigFormBase { 
    ];

  }



  /**

   * Configuration Factory.

   *

   * @var \Drupal\Core\Config\ConfigFactory

   */

  protected $configFactory;



  /**

   * Constructor.

   */

  public function __construct(ConfigFactory $configFactory) {

    $this->configFactory = $configFactory;

  }



  /**

   * {@inheritdoc}

   */
@@ -34,7 +49,7 @@ class FirstTimeLoginSettings extends ConfigFormBase { 
  public function buildForm(array $form, FormStateInterface $form_state) {

    // Form constructor.

    $form = parent::buildForm($form, $form_state);

    $config = \Drupal::configFactory()->getEditable('first_time_login.settings');

    $config = $this->configFactory->getEditable('first_time_login.settings');

    $form = [];



    $form['first_time_login_config_days'] = [
@@ -75,7 +90,7 @@ class FirstTimeLoginSettings extends ConfigFormBase { 
   */

  public function validateForm(array &$form, FormStateInterface $form_state) {

    if (!is_numeric($form_state->getValue('first_time_login_config_days'))) {

      $form_state->setErrorByName('first_time_login_config_days', t('Enter the number of days should be number.'));

      $form_state->setErrorByName('first_time_login_config_days', $this->t('Enter the number of days should be number.'));

    }

  }
@@ -83,7 +98,7 @@ class FirstTimeLoginSettings extends ConfigFormBase { 
   * {@inheritdoc}

   */

  public function submitForm(array &$form, FormStateInterface $form_state) {

    \Drupal::configFactory()->getEditable('first_time_login.settings')

    $this->configFactory->getEditable('first_time_login.settings')

      ->set('first_time_login_config_days', $form_state->getValue('first_time_login_config_days'))

      ->set('first_time_login_new_user_message', $form_state->getValue('first_time_login_new_user_message'))

      ->set('first_time_login_update_user_message', $form_state->getValue('first_time_login_update_user_message'))