Commit feebf73a authored by borisson_'s avatar borisson_ Committed by borisson_

Issue #2914630 by borisson_: Fix parereview issues

parent e510c8ec
......@@ -12,7 +12,7 @@
if (settings.facets.softLimit !== 'undefined') {
$.each(settings.facets.softLimit, function (facet, limit) {
Drupal.facets.applySoftLimit(facet, limit, settings);
})
});
}
}
};
......@@ -56,7 +56,7 @@
$(this).removeClass('open').text(showMoreLabel);
}
return false;
}).insertAfter($(this));
}).insertAfter($(this));
});
};
......
......@@ -291,7 +291,8 @@ class FacetListBuilder extends DraggableListBuilder {
'colspan' => 4,
],
];
foreach ($groups['lone_facets'] as $i => $facet) {
/** @var \Drupal\facets\FacetInterface $facet */
foreach ($groups['lone_facets'] as $facet) {
// Facets core search moved into a separate project. Show a clean
// message to notify users how to resolve their broken facets.
if (substr($facet->getFacetSourceId(), 0, 16) == 'core_node_search') {
......
......@@ -90,7 +90,7 @@ class BooleanItemProcessor extends ProcessorPluginBase implements BuildProcessor
public function supportsFacet(FacetInterface $facet) {
$data_definition = $facet->getDataDefinition();
$property_definitions = $data_definition->getPropertyDefinitions();
foreach ($property_definitions as $k => $definition) {
foreach ($property_definitions as $definition) {
if ($definition->getDataType() == "boolean") {
return TRUE;
}
......
......@@ -26,8 +26,6 @@ class DateItemProcessor extends ProcessorPluginBase implements BuildProcessorInt
* {@inheritdoc}
*/
public function build(FacetInterface $facet, array $results) {
$config = $this->getConfiguration();
return $results;
}
......
......@@ -142,7 +142,7 @@ class TranslateEntityProcessor extends ProcessorPluginBase implements BuildProce
public function supportsFacet(FacetInterface $facet) {
$data_definition = $facet->getDataDefinition();
$property_definitions = $data_definition->getPropertyDefinitions();
foreach ($property_definitions as $k => $definition) {
foreach ($property_definitions as $definition) {
if ($definition instanceof DataReferenceDefinitionInterface && $definition->getDataType() === 'entity_reference') {
return TRUE;
}
......
......@@ -46,7 +46,7 @@ class UidToUserNameCallbackProcessor extends ProcessorPluginBase implements Buil
public function supportsFacet(FacetInterface $facet) {
$data_definition = $facet->getDataDefinition();
$property_definitions = $data_definition->getPropertyDefinitions();
foreach ($property_definitions as $k => $definition) {
foreach ($property_definitions as $definition) {
if (
$definition instanceof DataReferenceDefinitionInterface &&
$definition->getDataType() === 'entity_reference' &&
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment