>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #366504. --> Reported by: [sbandyopadhyay](https://www.drupal.org/user/140596) >>> <p>I've combined several issues together into one patch:</p> <ul> <li><span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/email_registration/-/work_items/351511" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/email_registration/-/work_items/351511</a></span> <ul> <li>This patch changes the approach of the module. Instead of manipulating the database directly in <code>hook_user()</code> for the <code>insert</code> and <code>update</code> cases, this patch feeds the new username into the form on validate, and let's Drupal's native handling take care of the rest. This allows greater inter-operability in the workflow with other modules. </li><li>If the username is set to be equal to the email address per the flag on the admin page, then when users are allowed to edit their own username they should not see a separate username field. This patch checks for this in <code>hook_form_alter()</code> in the <code>user_edit</code> case, which <code>break</code>s immediately if the flag is false but carries through to <code>user_register</code> case if the flag is true. </li><li>And finally, I needed the super-admin (uid=1) to be able to pick the username without any interference from this module, so I just put in a quick check for that. Perhaps that can be made more customizable in the future, if you want the admin's username to remain the same as well? </li></ul> </li><li><span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/email_registration/-/work_items/241909" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/email_registration/-/work_items/241909</a></span> <ul> <li>A fairly simple and routine correction for missing <code>t()</code> fucntions. </li></ul> </li><li><span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/email_registration/-/work_items/345399" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/email_registration/-/work_items/345399</a></span> <ul> <li>The change in approach from the first patch above (<span class="drupalorg-gitlab-issue-link drupalorg-gitlab-link-wrapper"><a href="https://git.drupalcode.org/project/email_registration/-/work_items/351511" class="drupalorg-gitlab-link">https://git.drupalcode.org/project/email_registration/-/work_items/351511</a></span>) actually takes care of this as well. I've been using patch #1 with advanced profile, node profile, etc-- the new approach is more inter-operable with other modules, especially the ones mentioned by sethcohn in this issue. </li></ul> </li></ul> <p>There is slight change in setting up the module now:</p> <ul> <li><b>One less obligation:</b> This module's main page currently notes: "You will probably want to change the welcome e-mail (Administer -&gt; User Management -&gt; User Settings) and replace instances of the token !username with !mailto." This is <i>no longer</i> the case. This patch allows for normal "welcome!" emails from Drupal <i>without</i> any necessary changes. </li><li><b>One new obligation:</b> You must go to Administer -&gt; User Management -&gt; Access Control and allow authenticated users to change their own username. Otherwise, you'll get a validation error when users try to change their email address. </li></ul> <p>This is just for 5.x-1.x-dev release. I sadly don't have time to make a patch for 6.x.</p> >>> [!note] Pre-migration files - [master.patch](https://www.drupal.org/files/issues/master.patch) >>>