Issue #3311184 by jurgenhaas: Minor code style issues in plugin validation (d1a8531f) · Commits · project / eca

src/Entity/Eca.php

+4 −4

Original line number	Diff line number	Diff line
		@@ -314,7 +314,7 @@ class Eca extends ConfigEntityBase implements EntityWithPluginCollectionInterfac
		*/
		public function addCondition(string $id, string $plugin_id, array $fields): bool {
		$plugin = $this->conditionPluginManager()->createInstance($plugin_id, []);
		if (($plugin instanceof PluginFormInterface) && !$this->validatePlugin($plugin, $fields, 'action', $plugin_id, $id)) {
		if (($plugin instanceof PluginFormInterface) && !$this->validatePlugin($plugin, $fields, 'condition', $plugin_id, $id)) {
		return FALSE;
		}

		@@ -368,7 +368,7 @@ class Eca extends ConfigEntityBase implements EntityWithPluginCollectionInterfac
		*/
		public function addEvent(string $id, string $plugin_id, string $label, array $fields, array $successors): bool {
		$plugin = $this->eventPluginManager()->createInstance($plugin_id, []);
		if (($plugin instanceof PluginFormInterface) && !$this->validatePlugin($plugin, $fields, 'action', $plugin_id, $label)) {
		if (($plugin instanceof PluginFormInterface) && !$this->validatePlugin($plugin, $fields, 'event', $plugin_id, $label)) {
		return FALSE;
		}

		@@ -481,9 +481,9 @@ class Eca extends ConfigEntityBase implements EntityWithPluginCollectionInterfac

		// Now re-add the previously fetched messages.
		$messenger->deleteAll();
		foreach ($messages_by_type as $type => $messages) {
		foreach ($messages_by_type as $messageType => $messages) {
		foreach ($messages as $i => $message) {
		$messenger->addMessage($message, $type);
		$messenger->addMessage($message, $messageType);
		}
		}