## Problem A number of Action and ECA Condition plugins replace tokens in their configuration field values at runtime (via `TokenInterface::replace()`, `replaceClear()`, or `replacePlain()`), but their configuration form does **not** mark the corresponding form element with `#eca_token_replacement`. The `#eca_token_replacement` flag is what `PluginFormTrait::updateConfigurationForm()` uses to append the "This field supports tokens." hint to a field description and to render the token-info help block below the property panel. When a field is token-replaced at runtime but not marked, the UI misleads users into thinking the field does **not** support tokens, even though it does. This is purely a UI/discoverability defect — token replacement still works at runtime; the affected fields simply lack the documentation hint that all other token-aware fields show. ## How it was found Systematic audit of all 258 Action plugin files and 41 ECA Condition plugin files across `eca` core and its sub-modules. For every plugin, runtime replacement calls on `$this->configuration[...]` values were correlated with the `#eca_token_replacement` markers on the corresponding form elements, resolving inheritance through base classes and traits (e.g. `StringComparisonBase`, `FormFieldPluginTrait`, `RenderElementActionBase`, `ConfigActionBase`, `CacheActionBase`, `AddAttachedBase`, `AlterLinkAddAttribute`). ## Discrepancies — Actions | File (under `web/modules/contrib/eca/`) | Unmarked replaced field(s) | |---|---| | `modules/base/src/Plugin/Action/ErrorMessage.php` | `message` | | `modules/base/src/Plugin/Action/WarningMessage.php` | `message` | | `modules/base/src/Plugin/Action/KeyValueStoreBase.php` | `collection`, `key` | | `modules/base/src/Plugin/Action/TriggerCustomEvent.php` | `event_id` | | `modules/base/src/Plugin/Action/LockAcquire.php` | `lock_timeout` | | `modules/cache/src/Plugin/Action/RawCacheInvalidate.php` | `tags` | | `modules/cache/src/Plugin/Action/CacheActionBase.php` | `tags` | | `modules/config/src/Plugin/Action/ConfigRead.php` | `config_name`, `config_key` | | `modules/config/src/Plugin/Action/ConfigAction.php` | `action_id` | | `modules/config/src/Plugin/Action/ConfigWrite.php` | `config_name`, `config_key` | | `modules/content/src/Plugin/Action/CloneEntity.php` | `label`, `owner` | | `modules/content/src/Plugin/Action/NewEntity.php` | `label`, `owner` | | `modules/content/src/Plugin/Action/SetFormDisplay.php` | `display_mode` | | `modules/content/src/Plugin/Action/TriggerContentEntityCustomEvent.php` | `event_id` | | `modules/form/src/Plugin/Action/FormAddAjax.php` | `target`, `validate_fields` | | `modules/form/src/Plugin/Action/FormAddContainerElement.php` | `name` | | `modules/form/src/Plugin/Action/FormAddFieldActionBase.php` | `name`, `title`, `description`, `default_value` | | `modules/form/src/Plugin/Action/FormAddSubmitButton.php` | `name`, `value` | | `modules/form/src/Plugin/Action/FormAddGroupElement.php` | `name`, `title`, `introduction_text`, `summary_value`, `fields` | | `modules/form/src/Plugin/Action/FormFieldSetOptionsTrait.php` | `options` | | `modules/form/src/Plugin/Action/FormStateGetPropertyValue.php` | `property_name` | | `modules/form/src/Plugin/Action/FormStateSetPropertyValue.php` | `property_name` | | `modules/log/src/Plugin/Action/LogMessage.php` | `channel` | | `modules/queue/src/Plugin/Action/EnqueueTask.php` | `task_name`, `task_value` | | `modules/render/src/Plugin/Action/RenderElementActionBase.php` | `weight` (inherited by 8 subclasses) | | `modules/render/src/Plugin/Action/Image.php` | `uri`, `alt`, `title`, `width`, `height` | | `modules/render/src/Plugin/Action/Link.php` | `width` | | `modules/render/src/Plugin/Action/Details.php` | `title`, `introduction_text`, `summary_value` | | `modules/render/src/Plugin/Action/GetFileContents.php` | `uri` | | `modules/render/src/Plugin/Action/Views.php` | `display_id`, `arguments` | | `modules/user/src/Plugin/Action/NewUser.php` | `name`, `mail` | | `modules/views/src/Plugin/Action/ViewsQuery.php` | `display_id`, `arguments` | `RenderElementActionBase::weight` is a `textfield` whose value is passed through `replaceClear()` in `execute()` but is not marked. Fixing the base class resolves it for all 8 subclasses (`EntityForm`, `EntityViewField`, `EntityView`, `Image`, `Lazy`, `Link`, `Text`, `Unserialize`). ## Discrepancies — Conditions | File (under `web/modules/contrib/eca/`) | Unmarked replaced field(s) | Notes | |---|---|---| | `modules/base/src/Plugin/ECA/Condition/ListContains.php` | `value` | direct `replaceClear()` | | `modules/base/src/Plugin/ECA/Condition/EcaState.php` | `key`, `value` | `StringComparisonBase`, `$replaceTokens = TRUE` | | `modules/base/src/Plugin/ECA/Condition/ScalarComparison.php` | `left`, `right` | `StringComparisonBase`, `$replaceTokens = TRUE` | | `modules/content/src/Plugin/ECA/Condition/EntityFieldIsAccessible.php` | `field_name` | | | `modules/content/src/Plugin/ECA/Condition/EntityFieldValueChanged.php` | `field_name` | | | `modules/content/src/Plugin/ECA/Condition/EntityFieldValueEmpty.php` | `field_name` | | | `modules/content/src/Plugin/ECA/Condition/EntityFieldValue.php` | `field_name`, `expected_value` | `$replaceTokens = FALSE`, replaces internally | | `modules/content/src/Plugin/ECA/Condition/EntityFormDisplayMode.php` | `display_mode` | | | `modules/form/src/Plugin/ECA/Condition/FormOperation.php` | `operation` | | | `modules/form/src/Plugin/ECA/Condition/FormTriggered.php` | `trigger_name` | | | `modules/miscellaneous/src/Plugin/ECA/Condition/RouteMatch.php` | `route` | `StringComparisonBase`, `$replaceTokens = TRUE` | | `modules/user/src/Plugin/ECA/Condition/UserTrait.php` | `account` | trait used by several user conditions | ## Proposed resolution For each affected form element, add `'#eca_token_replacement' => TRUE` so the UI correctly advertises token support. Highest-leverage change is `RenderElementActionBase::weight` (fixes 8 plugins). For `StringComparisonBase` subclasses with the default `$replaceTokens = TRUE`, mark the value fields that feed `getLeftValue()` / `getRightValue()`. Fields that hold only a token **name** (`#eca_token_reference`) or a select option (`#eca_token_select_option`) are intentionally excluded — those are correct and must not be changed. ## Remaining tasks - [ ] Add `#eca_token_replacement` to the affected action form elements listed above. - [ ] Add `#eca_token_replacement` to the affected condition form elements listed above. - [ ] Verify no regression in existing kernel/functional tests for the touched plugins. ## User interface changes Affected configuration fields will now display the "This field supports tokens." hint and the token-info help block, consistent with all other token-aware fields.