Action "List: remove item (drop by specified value)" fails when value is a token
>>> [!note] Migrated issue
<!-- Drupal.org comment -->
<!-- Migrated from issue #3525806. -->
Reported by: [boromino](https://www.drupal.org/user/859722)
Related to !510
>>>
<h3 id="summary-problem-motivation">Problem/Motivation</h3>
<p>If the value to remove in the action List: remove item comes from a token, the value is not removed because the strict comparison of the properties with the value in \Drupal\eca\Plugin\DataType\DataTransferObject::remove() always returns false.</p>
<h4 id="summary-steps-reproduce">Steps to reproduce</h4>
<p>See attached ECA 2.0.x BPMN model:</p>
<ul>
<li>Without the fix, the list contains both items and the removed item is empty when viewing a content entity</li>
<li>With the fix, the list contains 1 item and the removed item is displayed when viewing a content entity</li>
</ul>
<h3 id="summary-proposed-resolution">Proposed resolution</h3>
<p>\Drupal\eca\Plugin\Action\ListRemoveBase::removeItem() already gets the value in the second condition if ($value instanceof TypedDataInterface). Move that code up to cover both cases.</p>
issue