Verified Commit fad60fd1 authored by Jibran Ijaz's avatar Jibran Ijaz
Browse files

Issue #2283919 by jibran: Fixed failing HEAD after PHPCS rules update. 

Signed-off-by: default avatarJibran Ijaz <jibran.ijaz@gmail.com>
parent 4a64d35c

dynamic_entity_reference.module

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ function dynamic_entity_reference_field_config_presave(FieldConfigInterface $fie 
  // dynamic_entity_reference_module_implements_alter().

  $selection_manager = \Drupal::service('plugin.manager.entity_reference_selection');

  $target_type = $field->getFieldStorageDefinition()->getSetting('target_type');

  list($current_handler) = explode(':', $field->getSetting('handler'), 2);

  [$current_handler] = explode(':', $field->getSetting('handler'), 2);

  $field->setSetting('handler', $selection_manager->getPluginId($target_type, $current_handler));

}

dynamic_entity_reference.views.inc

+2 −2
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ function dynamic_entity_reference_views_data() { 
  $entity_manager = \Drupal::entityTypeManager();



  /** @var \Drupal\Core\Entity\EntityTypeInterface[] $entity_types */

  list($entity_types, $sql_entity_types, $fields_all) = dynamic_entity_reference_get_all_base_fields();

  [$entity_types, $sql_entity_types, $fields_all] = dynamic_entity_reference_get_all_base_fields();



  $data = [];

  foreach ($fields_all as $entity_type_id => $fields) {
@@ -262,7 +262,7 @@ function dynamic_entity_reference_views_data_alter(&$data) { 
  $entity_manager = \Drupal::entityTypeManager();



  /** @var \Drupal\Core\Entity\EntityTypeInterface[] $entity_types */

  list($entity_types, $sql_entity_types, $fields_all) = dynamic_entity_reference_get_all_base_fields();

  [$entity_types, $sql_entity_types, $fields_all] = dynamic_entity_reference_get_all_base_fields();



  foreach ($fields_all as $entity_type_id => $fields) {

src/Plugin/Field/FieldWidget/DynamicEntityReferenceOptionsTrait.php

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ trait DynamicEntityReferenceOptionsTrait { 
   */

  public function massageFormValues(array $values, array $form, FormStateInterface $form_state) {

    foreach ($values as $index => $value) {

      list($values[$index]['target_type'], $values[$index]['target_id']) = explode('-', $value['target_id']);

      [$values[$index]['target_type'], $values[$index]['target_id']] = explode('-', $value['target_id']);

    }

    return $values;

  }

src/Plugin/Field/FieldWidget/DynamicEntityReferenceWidget.php

+2 −2
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ class DynamicEntityReferenceWidget extends EntityReferenceAutocompleteWidget { 
      // via the 'ValidDynamicReference' constraint.

      '#validate_reference' => FALSE,

      '#maxlength' => 1024,

      '#default_value' => isset($referenced_entities[$delta]) ? $referenced_entities[$delta] : NULL,

      '#default_value' => $referenced_entities[$delta] ?? NULL,

      '#size' => $this->getSetting('size'),

      '#placeholder' => $this->getSetting('placeholder'),

      '#element_validate' => array_merge(
@@ -285,7 +285,7 @@ class DynamicEntityReferenceWidget extends EntityReferenceAutocompleteWidget { 
      return parent::getSelectionHandlerSetting($setting_name);

    }

    $settings = $this->getFieldSettings();

    return isset($settings[$target_type]['handler_settings'][$setting_name]) ? $settings[$target_type]['handler_settings'][$setting_name] : NULL;

    return $settings[$target_type]['handler_settings'][$setting_name] ?? NULL;

  }



  /**