>>> [!note] Migrated issue <!-- Drupal.org comment --> <!-- Migrated from issue #1217286. --> Reported by: [webchick](https://www.drupal.org/user/24967) >>> <h3>Problem</h3> <ul> <li>After posting an issue comment, the issue summary <ul> <li>shows the comment author as issue summary author.</li> <li>creation date is changed to the time of the comment.</li> </ul> </li> </ul> <h3>Status</h3> <p>Issue is postponed and will be fixed during Drupal.org D7 upgrade.</p> <h3>Details</h3> <ul> <li>Issue summaries are based on node revisions. Issue nodes effectively have been turned into wiki pages.</li> <li>The expectation for updating issue summaries is: <ul> <li>the issue node author remains the same.</li> <li>the issue node body shows the current node revision.</li> <li>the author as well as the creation date of the issue summary (node revision) is output.</li> <li>the author and creation date of the current summary revision may be different to the node's author and creation date.</li> </ul> </li> <li>However, project_issue allows to update the issue node from the comment form. <ul> <li>A comment may change the issue title. The existing node revision is updated when a comment is posted.</li> <li>This updates the author and creation date info of the issue summary (node revision) to the current user posting the comment and the creation date of the comment.</li> <li>node_save() itself updates {node}.changed, and the helper function _node_save_revision() changes the node revision author to the currently logged in user.</li> </ul> </li> <li>project_issue keeps track of issue property changes in {project_issue_comments} - including the issue title - which allows to revert issue properties when unpublishing or deleting a comment.</li> <li>Issue queue views are based on {node_comment_statistics}, so not related to neither {node}.changed or {node_revisions}.timestamp. In other words: Not updating these columns doesn't change the behavior of issues going to the top of the queue after posing a comment.</li> </ul> <h3>Proposed solution</h3> <ul> <li>Don't make project_issue call node_save() when a comment is posted.</li> <li>Only update the issue node title, if it actually changed, and make sure to clear database and static caches afterwards.</li> </ul> <p><strong>Original summary:</strong></p> <h3>Problem</h3> <p>When posting an issue comment, project_issue_update_by_comment() calls <a href="http://api.drupal.org/api/drupal/modules--node--node.module/function/node_save/6">node_save()</a>, which does this asinine behaviour:</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; _node_save_revision</span><span style="color: #007700">(</span><span style="color: #0000BB">$node</span><span style="color: #007700">, </span><span style="color: #0000BB">$user</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">uid</span><span style="color: #007700">, </span><span style="color: #DD0000">'vid'</span><span style="color: #007700">);<br></span><span style="color: #0000BB">?&gt;</span></span></pre></div> <p>This ends up attributing the latest node revision to the currently logged in user, <em>destroying</em> the original author. See <a href="http://drupal.org/node/1036132/revisions">http://drupal.org/node/1036132/revisions</a> for example. The author of the revision on top will always match the author of the latest comment on the issue (currently set to xjm, node revision was actually authored by jhodgdon).</p> <p>There's an issue to fix this upstream in node_save() at <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-5"><a href="https://www.drupal.org/project/project_issue/issues/1217190" title="Status: Closed (won't fix)">#1217190: Interaction between project issue's comment behavior and node_save is causing revision author to update to comment author</a></span>; however, since that fix is likely a loonnnngg way off and d.o is actively losing revision authoring information now, it made sense to split this off into its own issue to see if it could be solved independently in PI module.</p> <h3>Proposed resolution</h3> <p>At <span class="drupalorg-gitlab-issue-link project-issue-status-info project-issue-status-5"><a href="https://www.drupal.org/project/project_issue/issues/1217190" title="Status: Closed (won't fix)">#1217190: Interaction between project issue's comment behavior and node_save is causing revision author to update to comment author</a></span>, mikey_p suggests the following options:</p> <p>1) mocking global $user (also oddly backed up by chx, as long as we wrap it like so to prevent accidental account hijacking:</p> <div class="codeblock"> <pre><span style="color: #000000"><span style="color: #0000BB">&lt;?php<br>session_save_session</span><span style="color: #007700">(</span><span style="color: #0000BB">FALSE</span><span style="color: #007700">); </span><span style="color: #0000BB">$user </span><span style="color: #007700">= </span><span style="color: #0000BB">user_load</span><span style="color: #007700">(</span><span style="color: #0000BB">$node</span><span style="color: #007700">-&gt;</span><span style="color: #0000BB">uid</span><span style="color: #007700">); </span><span style="color: #0000BB">node_save</span><span style="color: #007700">(</span><span style="color: #0000BB">$node</span><span style="color: #007700">); </span><span style="color: #0000BB">session_save_session</span><span style="color: #007700">(</span><span style="color: #0000BB">TRUE</span><span style="color: #007700">);<br></span><span style="color: #0000BB">?&gt;</span></span></pre></div> <p>2) mocking node_save() or something like it that can save the revision (if revision settings are set that way) or update the revision and node tables as needed, without overwriting node data with global vars. This would also require mocking all the nodeapi hooks, which is one of my bigger concerns as project* tends to rely on these for quite a bit of it's processing, and without them it's hard to tell what might break.</p> <p>There's also:</p> <p>3) (suggested by msonnabaum on IRC given his experience with node_save() and drush) Store the original $node-&gt;revision_uid and then do a direct UPDATE query to node_revision.uid to set it back after the fact when node_save() is done. Would break people using tools like <a href="http://drupal.org/project/mv">Materialized Views</a> to do data denormalization (wouldn't affect d.o, it appears, however).</p>