1. 04 Aug, 2004 3 commits
  2. 03 Aug, 2004 3 commits
    • Dries's avatar
      · c0f6fcca
      Dries authored
      - Patch #7336 by TDobes: in various parts of Drupal, we use the title attribute for links to provide a slightly more detailed explanation as to the purpose of a link or where it goes.
      c0f6fcca
    • Dries's avatar
      - Partial patch #9643 by Bart: · 254256de
      Dries authored
         + the confirmation before deleting a comment was missing a check_output.
         + after editing a comment, two pages were shown (two calls to theme('page',..)), replaced this by a drupal_goto.
      254256de
    • Dries's avatar
      · 0582a304
      Dries authored
      - Patch by Jeremy: statistics module improvements.
      0582a304
  3. 01 Aug, 2004 3 commits
    • Dries's avatar
      · a7a5f51c
      Dries authored
      - Simplified the block help a bit by removing some dated information.  It
        should be simplified more.
      a7a5f51c
    • Dries's avatar
      · 4aefe695
      Dries authored
      - Fixed broken link + removed redundant form descriptions (there is no point
        in repeating the title).
      4aefe695
    • Dries's avatar
      619bb4a4
  4. 31 Jul, 2004 6 commits
    • Dries's avatar
    • Dries's avatar
      · 64dae93a
      Dries authored
      - Patch #9654 by Bart: since the $category paramater was added to user_save,
        update 80 (moving the profile fields to their own tables) no longer works.
      64dae93a
    • Dries's avatar
      - Patch #9649 by JonBob: fixed a buglet in the recent book patch. It tried · f97c3367
      Dries authored
        to set book breadcrumbs for nodes that weren't books.
      f97c3367
    • Dries's avatar
      - Patch by Matt: fixed small typo. · ca3e769f
      Dries authored
      ca3e769f
    • Dries's avatar
      · 9945bca5
      Dries authored
      - Patch #9650 by Adrian: this change introduces a module_load function, which maintains a list of modules that have already been loaded in a static array, and will not load another module of the same name, or if the file does not exist.
      
      Modules can be stored anywhere, as there is now a set of functions called module_get_filename, and module_set_filename .. which allow system_listing and module_list to specify the locations of the files.
      
      A new function module_load_all() replaces the hardcoded includes in module_init, and loads all modules which have been enabled, using module_load.
      
      module_listing no longer includes files itself, instead it just keeps the listing (and sets the filenames).
      
      This patch is a requirement for the multisite configuration patch, as overriding modules are currently being loaded due to the only protection of loading them is include_once.
      9945bca5
    • Dries's avatar
      · 202eee42
      Dries authored
      - Patch #9543 by JonBob: added node-level access control!
      202eee42
  5. 30 Jul, 2004 1 commit
    • Dries's avatar
      · aed1b0ca
      Dries authored
      - Patch #5347 by JonBob:
      
      Here's a new patch that unifies the node/52 and book/view/52 paths for nodes. It involves a small change to hook_view(), which is discussed first:
      
      Currently hook_view() expects node modules to return a themed node. However, each module does this the same way; they modify $node as necessary, then call theme('node', $node) and return the result. We can refactor this so that the calling function node_view() calls theme('node') instead. By doing this, it becomes possible for hook_nodeapi('view') to be called after hook_view() where the node contents are filtered, and before theme('node') where the body is enclosed in other HTML. This way the book module can insert its navigation into the body right before the theming.
      
      Advantages of this refactoring:
      - I can use it for book.module to remove the extra viewing path.
      - The function of hook_nodeapi('view') becomes more like hook_view(), as neither will expect a return value.
      - We more closely follow the flow of other nodeapi calls, which usually directly follow their corresponding specific node type hooks (instead of preceding them).
      - The attachment.module people could use it to append their attachments in a list after the node.
      - Gabor could use it instead of his filter perversion for his "articles in a series" module.
      - A little less code in each view hook.
      - The content hook is no longer needed, so that means even less code.
      
      Disadvantages:
      - Any modules written to use nodeapi('view') could be affected (but these would all be post-4.4 modules).
      - Implementations of hook_view() would need to be updated (but return values would be ignored, so most would work without updates anyway).
      
      Now the patch takes advantage of this API shift to inject its navigation at the end of all book nodes, regardless of the viewing path. In fact, since the paths become identical, I've removed the book/view handler entirely. We should probably provide an .htaccess rewrite for this (one is still needed for node/view/nn anyway). At the same time, there is a check in book_block() that shows the block appropriately on these pages.
      aed1b0ca
  6. 29 Jul, 2004 1 commit
    • Steven Wittens's avatar
      Fixing a rather nasty bug with page cache: · 6c73823b
      Steven Wittens authored
      The headers stored for cached pages ended in a newline, which caused header("") to get called when serving the page.
      On some PHP versions (happens on 4.3.3 at least, but not in 5.0), PHP adds a blank header to the HTTP request (i.e. just \r\n) which ends HTTP headers prematurely and adds a newline at the beginning of the page.
      
      This was not an issue before because we output HTML. Now that we have GZip compression, this bug caused corruption of the output. :P
      *phew*
      6c73823b
  7. 28 Jul, 2004 3 commits
  8. 26 Jul, 2004 1 commit
    • Dries's avatar
      · d21207ae
      Dries authored
      - Patch #8531 by drumm: took this date parser from MagpieRSS (conveniently GPL). The main benefit here is that timezones are handled properly (I have been noticing increasing complaints about that). I tested with a few feeds of different time formats and time zones and everything appeared correctly in my site's local time. Making this another function adds the benefit of parsability by other RSS (or other contexts) and RSS extension handling functions, where the W3C DTF is recomended.
      d21207ae
  9. 25 Jul, 2004 8 commits
    • Steven Wittens's avatar
      CSS improvements: · ad5e3ebb
      Steven Wittens authored
      - Restoring background coloring for the watchdog logs (was broken)
      - Making watchdog backgrounds lighter, makes it easier on the eyes and improves readability.
      - Adjusted the spacing between items on the frontpage a bit to be clearer.
      - Fixed the vertical stretching of table rows with form controls in them.
      ad5e3ebb
    • Steven Wittens's avatar
      ef6cbfda
    • Dries's avatar
      · f2ac51dc
      Dries authored
      - Patch #9346 by drumm: improved themability of some aggregator pages.
      f2ac51dc
    • Dries's avatar
      · f4460da9
      Dries authored
      - Patch 9543 by JonBob: use drupal_goto() in menu administration.
      f4460da9
    • Dries's avatar
      · 2af5dff6
      Dries authored
      - Patch #9464 by Moshe: menu.module omitted a pair of braces when calling
        db_next_id().
      2af5dff6
    • Dries's avatar
      177c93f2
    • Dries's avatar
      · 702a0576
      Dries authored
      - Patch #9478 by JonBob: allow printf-style arguments in pager_query.
      
        Currently pager_query() is the black sheep of the database query family, because it does not allow for printf-style arguments to be inserted in the query. This is a problem because it introduces developer confusion when moving from an unpaged query to a paged one, and it encourages substitution of variables directly into the query, which can bypass our check_query() security feature.
      
        This patch adds this ability to pager_query(). The change is backwards-compatible, but a couple calls to the function in core have been changed to use the new capability.
      702a0576
    • Dries's avatar
  10. 23 Jul, 2004 1 commit
  11. 22 Jul, 2004 3 commits
  12. 21 Jul, 2004 3 commits
  13. 16 Jul, 2004 1 commit
    • Dries's avatar
      · 2a538a39
      Dries authored
      - Patch by Andy: improved help text / module description.
      2a538a39
  14. 15 Jul, 2004 2 commits
    • Dries's avatar
      · 8aa052dc
      Dries authored
      - Patch #9177 by James: fixed distributed authentication.
      8aa052dc
    • Dries's avatar
      · 7765fa1f
      Dries authored
      - Patch #9290 by Morbus / JonBob / TDobes: SUBTASK removal patch for menu.inc.
      7765fa1f
  15. 14 Jul, 2004 1 commit