1. 23 Feb, 2012 5 commits
  2. 22 Feb, 2012 5 commits
  3. 17 Feb, 2012 8 commits
  4. 16 Feb, 2012 13 commits
  5. 14 Feb, 2012 9 commits
    • sun's avatar
      Fixed ImageDimensionsUnitTest does not apply weights to image effects, so... · 2b316b6a
      sun authored
      Fixed ImageDimensionsUnitTest does not apply weights to image effects, so effects are not saved in expected order.
      2b316b6a
    • sun's avatar
      Removed wonky code in image_effect_save() that seemingly and bogusly tries to... · 7f7d3555
      sun authored
      Removed wonky code in image_effect_save() that seemingly and bogusly tries to retain previously existing properties of an image effect.
      7f7d3555
    • sun's avatar
      Fixed missing type casting for configuration values. · 4f0f3c87
      sun authored
      4f0f3c87
    • sun's avatar
      Fixed Image module tests. Added many critical todos: · 40cc21c8
      sun authored
      - Config values are not casted to strings (despite promised).
      - Config keys are not casted to strings (although promised, too).
      - XML can be invalid and not parse-able for many reasons.
      - Config keys are not validated/sanitized.
      - config()->clear() should really be ->unset().
      - Configuration must not be additionally cached by a module in any way (static cache / database cache).
      - Some modules invoke drupal_alter() on configuration (e.g., image styles).
      - Need a way to list config object names/suffixes _after_ a specified prefix.
      - Need a way to determine whether a config object exists.
      - Some modules might have a valid use-case for retrieving/listing config objects using a wildcard within the name (instead of only searching by prefix).
      - The key of a retrieved value is unknown; since you only get the value.  Configuration values (or sub-values) may be passed forward to another function/callback, and thus, that function no longer knows about the key of the value. (unless the key is contained in the value, which is a very very wonky duplication)
      - Config keys must not contain periods (within a specific key).
      40cc21c8
    • sun's avatar
      Fixed Config module .info definition. · d74f856c
      sun authored
      d74f856c
    • sun's avatar
      Fixed CommonJavaScriptTestCase. · 23ecfa94
      sun authored
      23ecfa94
    • sun's avatar
      Fixed coding style. · 64eb1643
      sun authored
      64eb1643
    • sun's avatar
      Added todo for basic CRUD tests. · 51cd608b
      sun authored
      51cd608b
    • sun's avatar
      Fixed ImageDimensionsUnitTest. · 588cfd8b
      sun authored
      588cfd8b