1. 21 Apr, 2003 1 commit
    • Dries's avatar
      · a956de78
      Dries authored
      - Fixed some PHP "notices".
      a956de78
  2. 04 Mar, 2003 1 commit
    • Dries's avatar
      · 40abf506
      Dries authored
      - Fixed "undefined index/variable" warning.  Patch by Ax.
      40abf506
  3. 15 Feb, 2003 1 commit
    • Dries's avatar
      · 83f5d828
      Dries authored
      - Everything is using theme("function") now instead of $theme->function().
      83f5d828
  4. 06 Jan, 2003 1 commit
    • Dries's avatar
      · 89b2069e
      Dries authored
      - Clean URL patch.
      89b2069e
  5. 04 Jan, 2003 1 commit
    • Dries's avatar
      · 56e5c29b
      Dries authored
      - Added a check for register_globals.
      56e5c29b
  6. 26 Dec, 2002 1 commit
    • Dries's avatar
      · 26e0b9b7
      Dries authored
      - Made Drupal report an error when magic_quotes are disabled.
      26e0b9b7
  7. 18 Oct, 2002 1 commit
    • Dries's avatar
      · 2e43215b
      Dries authored
      - Removed dead code.
      2e43215b
  8. 14 Apr, 2002 1 commit
    • Kjartan's avatar
      This is a major change to the system, needs more testing! · 55927616
      Kjartan authored
      Committing Changes by Moshe Weitzman:
      - admin_user_account(), user_edit(), and user_view() no longer have any
        hard code for authentication modules. instead authentication modules
        implement the _user hook.
      - fixed a couple 'help' typos.
      - linked the 'REGISTER' text in the login block to the register page.
        this page now advertises DA better if site employs DA.
      - admins may now edit everything about a user account (was a feature
        request).
      - user #1 may now login immediately, in addition to receiving his
        password via email.
      
      Other changes:
      - modules and themes are now enabled/disabled in the administrative /
        settings / modules | themes pages. Requires SQL update and things must
        be enabled before your site returns to normal. TODO: enable all
        functionality. (For now just do UPDATE system SET status = 1;)
      - removed $themes from conf.php.
      - added a $theme->system() function where theme can specify settings.
        All themes in the Drupal CVS have been updated to use this.
      - added _system hook to modules. TODO: update modules to use this.
      - changed strange use of sprintf to the usual strtr. The disadvantage of
        sprintf is that it requires translations to keep the string order,
        which may not be possible in all languages.
      - an invalid/nonexisting theme in a user profile will now fallback to the
        BaseTheme instead of crashing.
      55927616
  9. 17 Nov, 2001 1 commit
  10. 01 Nov, 2001 1 commit
    • Dries's avatar
      · 336b713a
      Dries authored
      - A large batch of updates, amongst them a rewritten node system.  More
        information available on the mailing list.
      336b713a
  11. 20 Oct, 2001 2 commits
  12. 27 Sep, 2001 1 commit
    • Dries's avatar
      · 4a0e498f
      Dries authored
      - a batch of updates, including some experimental changes to the moderation
        of comments and nodes.
      4a0e498f
  13. 25 Sep, 2001 1 commit
  14. 18 Sep, 2001 1 commit
    • Dries's avatar
      · ca85a56f
      Dries authored
      - Fixed 2 typos in the user module.  Thanks Axel and Remco.
      - Applied (modified versions of) Alexander's patches on the development
        branch.
      ca85a56f
  15. 30 Jun, 2001 1 commit
    • Dries's avatar
      · f70002b7
      Dries authored
      - Fixed typo.
      f70002b7
  16. 29 Jun, 2001 1 commit
    • Dries's avatar
      · 9c43e8fc
      Dries authored
      Extremely large commit:
      
      - Fixed tiny quote problem in account.php.
      
      - Fixed tiny bug in comment.inc.
      
      - Fixed tiny bug in comment.module.
      
      - Fixed tiny bug in meta.module.
      
      - Simplified user_access() API.
      
      - Rewrote link system: still needs fine-tuning and testing so don't
        upgrade if you are running a production site. ;)
      
        Updated all modules and themes to reflect this change.  All other
        themes and modules need updating too!
      9c43e8fc
  17. 20 Jun, 2001 1 commit
    • Dries's avatar
      · 72065fb8
      Dries authored
      - Added a brand-new access.module which allows you to manage 'roles'
        (groups) and 'permissions' ... (inspired by Zope's system).
      
          + Once installed, click the help-link for more information.
      
          + See updates/2.00-to-x.xx.sql for the SQL updates.
      
      - Modified loads of code to use our new access.module.  The system
        still has to mature though: new permissions have to be added and
        existing permissions need stream-lining.  Awaiting suggestions.
      
      - As a direct result of the new access system, I had to rewrite the
        way the top-level links in admin.php are rendered and displayed,
        and xhtml-ified admin.php while I was at it.
      
      TODO
      
      - Home-brewed modules need updating, home-brewed themes not.
        (Examples: file.module, trip_link.module)
      
      - As soon we *finished* the refactoring of the user system (KJ has
        been working on this refactoring already) we should consider to
        embed this role and permission code into account.module ...
      72065fb8
  18. 17 Jun, 2001 1 commit
    • Dries's avatar
      · 03c06a86
      Dries authored
      Oops, a rather large commit:
      
      - Changed meta.module, node.module and index.php to use comma-seperated
        lists of attributes rather then "foo=a,bar=b" lists.  This makes it a
        a lot easier to use both modules.  In addition, error handling can be
        discarded as it can't be made any simpler, really ...
      
        It fits rather nicely in Drupal's design so I'm getting more and more
        happy with this meta.module (but we are not 100% there yet).
      
      - node.module, node.inc:
      
         + Improved the node-related admin interface so that navigating back
           and forth the administrative menus is made both easier and faster.
      
         + Removed some redundant database fields from the node table.  See
           2.00-to-x.xx.sql!
      
         + Added 2 news hooks called "node_insert" and "node_update".  Just
           like this is the case with the existing hook "node_delete" these
           new hooks will automatically get called when a node has been
           inserted or udpated.  Note that this is an optional call-back that
           only needs to be implemented when required.  With the addition of
           these two hooks, the node mechanism (version 1) is pretty well
           completed.
      
      - watchdog.module:
         + Fixed bug whit the 'regular messages' query in the watchdog.module.
      
      - book.module:
         + Fixed bug in book.module: the 'parent' was not set properly when
           updating a book page.
         + Made it so that older versions of a book page are automatically
           reactived upon deletion of the most recent version, i.e. when
           doing a version roll-back.
      
      - comment.inc:
         + Undid Remco's patch to comment.inc; it does not work in some cases.
      
      
      - conf.module:
         + Fine-tuned some of the options in conf.module a bit.
      
      - marvin.theme:
         + Visual changes to make it look better on Windows browsers.  Mind
           to give some feedback on this?
         + Fixed 3 HTML typos/bugs.
         + XHTML-ified the theme at a best effort basis; I didn't carry the
           XHTML specification with me.
         + Made use of the theme_slogan variable to display the site's slogan.
         + As soon we have at least one valid XHTML theme we can wonder on how
           to integrate other XML namespaces (cfr. MathML story at drop.org).
      
      - database.mysql:
         + Updated database.mysql so that it contains all the latest "database
           patches".
      03c06a86
  19. 15 Jun, 2001 1 commit
    • Dries's avatar
      · bfa80297
      Dries authored
      - Made index.php work with new meta.module.
      bfa80297
  20. 10 Jun, 2001 1 commit
    • Dries's avatar
      · d397bbe9
      Dries authored
      This a rather large commit that needs a lot of fine-tuning.  If you
      update, you'll break your site as you need switching from structure
      to index.module: so this can be considered an intermediate commit.
      
      If you upgrade, and you are welcome to, just create a collection
      called "section" (for now) and assign your nodes some attributes
      in the described format.
      
      Feedback and bugreports are welcomed.  Questions will be answered.
      
      CHANGES:
      
      - comment system:
         + when replying to a node (rather then to a comment), that
           node is displayed above the reply form.
         + when replying to a comment (rather then to a node), that
           comment is displayd above the reply form.
      
      - removed structure.inc, removed structure.module.
      
      - node.inc:
         + added 2 new node functions called 'node_attribute_edit()' and
           'node_attribute_save()' used to 'hook in' any indexing system
          including your home-brewed stuff if you'd want to.  Currently,
          index.module is the facto default index system.
      
          See story.module for usage.
      
      - book.module, story.module, poll.module, page.module, forum.module:
         + added preview functionality to administration section (via node
           module).
         + removed all references to structure.inc (category, topic).
      
      - moderate.module:
         + removed all references to structure.inc (category, topic).
      
      - book.module, story.module, page.module, forum.module:
         + increased the sizes of some textareas.
      
      - submit.php:
         + removed all references to structure.inc (category, topic).
      
      - marvin.theme:
         + removed dead code: function story() was depricated.
      
      - unconed.theme:
         + removed hardcoded references to drop.org.
      
      - marvin.theme, unconed.theme, jeroen.theme, yaroon.theme, example.theme:
         + removed all references to structure.inc (category, topic).
      
      TODO:
      
      - file.module, trip_link.module:
         + update preview functionality:
             see story.module for example.
         + remove references to 'cid' and 'tid', use 'attribute' instead:
             see story.module for example.
      
      - extend and build upon index.module as well as making it configurable
      d397bbe9
  21. 02 Jun, 2001 1 commit
    • Dries's avatar
      · b0c349e2
      Dries authored
      - Moved most of the options in structure.module to node.module.  The
        structure.module either needs work, or replacement by index.module:
        see "admin > node > node settings".
      
        It will do for now and it can always made better when we can think
        of a better solution; it is the best I could think of.   Now what?
        index.module or structure.module?  I'm currently pro index.module.
      
      - Drastically simplified "variable.inc".
      
      - Removed most dependecies on structure.module from all content related
        modules.  Thus making our modules more modular.  ;)
      
      - Fixed calculation glitch in queue.module.
      
      - Fixed potential function name clash/conflict in rating.module, and
        simplified some code on my way.
      
      - Started removing all global variables $status and $rstatus.  Global
        variables are "yucky" so in near future, we will replace all global
        $status variables by a call to node_status().  Originally, $status
        was only introduced as a temporary hack and nothing is as permanent
        as a temporary hack so I took it out when still possible.
      
      - Changed the watchdog messages a bit.
      b0c349e2
  22. 20 May, 2001 3 commits
    • Dries's avatar
      · 4f1cf00f
      Dries authored
      - Improved node_get() so that it will try to skip one additional query
        if possible (ie. to reduce the number of queries).
      
      - Automatically removed tabs and trailing spaces from the poll.module.
      4f1cf00f
    • Steven Wittens's avatar
      - Changed the node_get_object() and node_get_array() functions to allow multiple conditions · 27496c46
      Steven Wittens authored
      - Added the "delete" hook for node-modules. When called, a module should do additional clean-up if necessary.
      
      - Updated all node-modules
      27496c46
    • Dries's avatar
      CHANGES · 20397ad3
      Dries authored
      - Redid settings.module and even renamed it to conf.module.
          * Settings are now grouped in basic categories like "system
            settings", "module settings" and "filters".
        * Added new settings to make Drupal easier to configure and
        to make some aspects like the watchdog scale better.
      
      - Renamed includes/settings.php to includes/conf.php.
      
      - Added filter support to conf.module and introduced filter hooks so
        modules can implement and export new filters.  Example filters are
        an HTML filter (implemented), a profanity filter, an url converter,
        ASCII smileys to images filter and so on ...
      
      - Reworked the check_* functions: user contributed content/input is
        only verified and filtered once in its lifespan.
      
      NOTES
      
      - Altough this is a large commit, no database changes are required.
      20397ad3
  23. 12 May, 2001 1 commit
    • Dries's avatar
      · 86bb9a10
      Dries authored
      - Made the main page display sub-topics when a specific topic
        is selected.
      
      - Made theme_link() less "hard coded", we still have to make
        it fully configurable though.
      
      - Fixed glitch in story submission: the warning messages were
        not displayed.
      
      - Tidied up block.module a bit.
      86bb9a10
  24. 06 May, 2001 1 commit
    • Dries's avatar
      · 25c379fb
      Dries authored
      - Added custom PHP error handler to track down warnings and errors.
        (Jeroen: let's sit back and wait until that warning bites again.)
      
      - Simplified drupal.module.  We still need a feature list, anyone?
      25c379fb
  25. 30 Apr, 2001 1 commit
    • Dries's avatar
      · fead09a8
      Dries authored
      Welp.  Large commit ahead.
      
      CHANGES:
      
      - Added "read" and "write" permissions into drupal but removed
        it again because - when finished after 3 hours of work - it
        was considered nothing but added complexity that didn't buy
        us anything. :I
      
        (I'll explain this in detail on the mailing list, I guess.)
      
      - Added a very simple help.module to group all available
        documentation on a single page.
      
      - Fixed bug in node_control(), book.module: UnConeD forgot to
        global $user when updating the combobox code.
      
      - Removed static wishlist.module: in future, the wishlist can
        be maintained as a page in our collaborative book.
      
      - Revised most of settings.module: tidied up the code and the
        descriptions to accompany the settings and introduced a new
        "default maximum number of nodes to display on the main page"
        variable.
      
      - Revised most of comment.module: the administration interface
        looks better now, integrated node permissions, and -finally-
        made it possible to delete comments.
      
      - Polished on:
         + account.module
         + structure.module
         + locale.module
         + module.module
         + forum.module
      
      - Form-ified:
         + account.php
         + account.module
         + setting.module
         + cvs.module
         + submit.php
         + comment.module
         + forum.module
         + book.module
         + page.module
         + locale.module
      
      - Updated CHANGELOG
      
      INFO:
      
      - Designed a "generic tracker system with optional backends"
        on paper.  The idea is to allow registered users to hot-list
        certain topics, individual nodes or threads (comments) and
        to "plug-in" output backends like - for instance - an e-mail
        digest.  The design requires "intelligent blocks" though.
      
      
      TODO:
      
      - I want to tidy up the headline.module and backend.class as
        well as merge in headlineRSS10.module.  Julian spent quite
        some time working on headline.module but I'm not sure what
        he changed and whether he'd contribute it back?
      fead09a8
  26. 21 Apr, 2001 1 commit
    • Dries's avatar
      · cccb132c
      Dries authored
      - Addition: added a "promote" field to the node table, which
        makes "promoting nodes" to the main page possible.  Stories
        and reviews could be promoted by default, but - on accasion
        a good book entry could be manually promoted too.  Thus all
        existing content types can be shown on the main page, not
        just stories.
      
        Requires a SQL update, see 2.00-to-x.xx.sql!
      
      - Addition: implemented "auto-post new submissions" feature
        to disable or by-pass the moderation queue in addition to
        "moderate new submissions".
      
        TODO: admin moderation versus registered user moderation.
      
      - Addition: added category and topic support to page.module.
      cccb132c
  27. 16 Apr, 2001 2 commits
    • Dries's avatar
      · b1c66cb5
      Dries authored
      Another big update so please read this carefully because there is important information hidden in it.
      
      Made it so that we can disable/enable comments on a category by category basis. In order to accomplish this I had to make a few (*temporary*) changes.
      
      I moved all comment code from the "module level" (eg. story.module) to the "node level".  It was nothing but the logical next step in nodifying drupal.  This enables us to add comments to all existing content types including book entries.  But also for book entries, this to can be toggled on and off. :-)
      
      Moreover module writers don't have to worry about the complex comment logic: it is "abstracted" away.  This implies that story.module got smaller, faster and easier to comprehend. :-)
      
      In order to accomplish this, I had to update ALL THEMES, which I did - and on my way I updated Goofy, Oranzh and UnConeD - with the previous changes.  All themes are up-to-date now!  I also had to remove the [ reply to this story ] links, and temporally re-introcuded the "Add comment" button in the "Comment control".  Tempora lly that is, UnConeD. ;)
      
      I plan to upgrade drop.org either tommorow or wednesday so test away if you have some time to kill. ;)
      
      Oh, I also fixed a few bugs and made various small improvements.
      b1c66cb5
    • Dries's avatar
      · b9952f53
      Dries authored
      Large commit, read it carefully, and make the required changes to
      your theme:
      
      - corrected some missing translations in story.module.  Oops!
      - grealty simplified the "moderation threshold mechanism"(tm) so
        that module writers don't have to worry about this.  As a result
        story.module and book.module became a bit smaller and easier to
        grasp.
      - greatly simplified new "category" and "topic" code which is soon
        going to replace the "section" code.  Needs more work though so
        hang on thight.
      - includes/section.inc and modules/section.module are replaced by
        includes/structure.module and modules/structure.module.
      - beautified example.theme a bit without adding HTML complexity:
        it is a good example but still useful as a theme
      - made theme example use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - made theme marvin use "categories" and "topics"
          --> TAKE A LOOK AT IT AND UPDATE YOUR THEME
      - added 2 new "story listings" to administrator interface of
        story.module to verify story integrity.
      - optimized comment table a bit (work in progress)
      b9952f53
  28. 15 Apr, 2001 1 commit
    • Dries's avatar
      · 1f056580
      Dries authored
      - improved submit.php:
        it now uses the new category code, incl content bindings.
        You can setup different "categories" which map on a content
        type.  Example:
          review   -> review.module
          article  -> story.module
          column   -> story.module
          announc. -> story.module
          addons   -> file.module
          themes   -> file.module
      - "generalised" story.module and book.module's output.
      - fixed bug in includes/timer.inc
      - fixed glitch in theme example.theme: it said "$how by" but
        the variable $how has never been declared.
      - added "drupal development settings" to display some timings
      - more work on the categories/topics -> does NOT work yet
      1f056580
  29. 29 Mar, 2001 1 commit
    • Dries's avatar
      · 04ad9b8a
      Dries authored
      - fixed issue depricated call-by-reference issues
      - fixed small visual glitch in includes/function.inc
      - changed SQL tables around a bit to be more consistent
        (result: small changes to a lot of different files)
      - improved robustness of includes/node.inc
      - improved output of cron.module
      - improved output of node.php
      04ad9b8a
  30. 25 Mar, 2001 1 commit
    • Dries's avatar
      · 1f798630
      Dries authored
      - large commit of everything else that has been queued in my backlog:
        it's not 100% stable yet
      1f798630
  31. 24 Mar, 2001 1 commit
    • Dries's avatar
      · 68f2112b
      Dries authored
      - nodified index.php:
          the index page will only display stories for now but this will/can
          change in the near future
      - all other files now thinks in terms of nodes, rather then stories
      68f2112b
  32. 10 Mar, 2001 1 commit
    • Dries's avatar
      · accd5f0c
      Dries authored
      - applied David Norman's patch to turn all <?'s into fully qualified
        <?php's.
      accd5f0c
  33. 08 Mar, 2001 1 commit
    • Dries's avatar
      · 3958a714
      Dries authored
      - some important changes to our theme API which can be summerized as:
      
           abstract() + article() = story()
      
        abstract() and article() have been merged into a new function story()
        which looks like:
      
        function story($story_object, $reply) {
          if (!reply) {
             // full story
          }
          else {
             // main page version / abstract
          }
        }
      
        This should allow you to "compress" your theme as abstract() and
        article() tended to be 98% identical.
      
        => I didn't really merge your themes so I leave it up to *you* to
           improved the code!!! Do it ASAP as we release drupal 2.00 in 7
           days.
      
        In future we'll have similar functions for other content types as
        for example:
      
           review($review, $reply);
           enquete($enquete, $reply);
           ...
      3958a714
  34. 07 Mar, 2001 1 commit
    • Dries's avatar
      · f516626a
      Dries authored
      A rather large and important update:
      
      revised most of the SQL queries and tried to make drupal as secure as possible (while trying to avoid redundant/duplicate checks).  For drupal's sake, try to screw something up.  See the mail about PHPNuke being hacked appr. 6 days ago.  The one who finds a problem is rewarded a beer (and I'm willing to ship it to Norway if required).  I beg you to be evil.  Try dumping a table a la "http://localhost/index.php?date=77778;DROP TABLE users" or something. ;)
      f516626a
  35. 04 Feb, 2001 1 commit
  36. 21 Jan, 2001 1 commit
    • Dries's avatar
      · ea978885
      Dries authored
      I know, I know, it is getting nasty lately but I have another large commit after nothing but code.
      
      This time I redid the "category"-stuff.  Categories - from now on called sections - are now maintained from the admin pages, can have their own post, dump and timout thresholds as discussed earlier (some weeks ago).  By tomorrow evening users will be able to enable or disable section as well - i.e. to customize the content of drop.org.
      ea978885