1. 07 Apr, 2006 1 commit
  2. 06 Apr, 2006 3 commits
  3. 31 Mar, 2006 1 commit
  4. 27 Mar, 2006 1 commit
  5. 25 Mar, 2006 1 commit
  6. 24 Mar, 2006 1 commit
  7. 23 Mar, 2006 1 commit
  8. 08 Mar, 2006 2 commits
  9. 07 Mar, 2006 1 commit
    • Dries's avatar
      - Patch #52850 by Zen: fapi conversion + minor fixes · d2865f2a
      Dries authored
          * converts forum_admin to fapi.
          * handles invalid terms in hook_menu
          * adds comments, fixes typos etc.
          * reorganises functions a little bit - moves hook_menu to the top.. groups hooks together and forms together
      d2865f2a
  10. 03 Mar, 2006 1 commit
  11. 28 Feb, 2006 1 commit
  12. 23 Feb, 2006 1 commit
  13. 21 Feb, 2006 1 commit
  14. 15 Feb, 2006 1 commit
  15. 10 Feb, 2006 1 commit
  16. 09 Feb, 2006 2 commits
  17. 04 Feb, 2006 1 commit
  18. 01 Feb, 2006 1 commit
  19. 20 Jan, 2006 1 commit
    • Dries's avatar
      - Patch #45530 by Morbus: filter_form shouldn't default to #weight 0 · 8c02d4ec
      Dries authored
      When a form element doesn't specify a #weight, it is assumed internally as #weight 0. However, to ensure that our form elements display visually *as they were defined in the array* we, in form_builder, count the number of elements, divide by 1000, and set that as the weight:
      
      # Assign a decimal placeholder weight to preserve original array order
      if (!isset($form[$key]['#weight'])) {
        $form[$key]['#weight'] = $count/1000;
      }
      
      The above code will set the #weights of elements that have not defined a weight to something like 0 (first element in array definition), 0.001, 0.002, and so on. However, anytime a form element *explicitly* defines a #weight of 0, that #weight is kept at exactly 0, which would cause that form element to appear BEFORE the elements that didn't have a #weight defined (and thus received a #weight such as 0.002).
      
      Consider the following pseudo example:
      
      $form['game_title'] = array(
          '#type' => 'textfield',
          ...
          );
      $form['game_description'] = array(
          '#type' => 'textarea',
          ...
          );
      $form['game_format'] = filter_form(variable_get('game_format', NULL));
      return $form;
      
      Here, we're not definiing weights on our two textfields. We then add an filter_form. The second parameter of the filter_form is $weight, which defaults to 0. After this $form hits form_builder, we have weights 0 (game_title), 0.001 (game_description), and 0 (filter_form) respectively. This is then sorted by weight, which causes filter_form (the third element in the array) to appear BEFORE game_description (0 is lighter than 0.001).
      
      The short lesson is: explicitly defining #weight 0 for a form element is probably a bad idea. This patch changes the default #weight of filter_form to NULL, instead of 0, and also removes any other explicit setting of #weight to 0 in core.
      8c02d4ec
  20. 19 Jan, 2006 2 commits
  21. 18 Jan, 2006 1 commit
  22. 10 Jan, 2006 1 commit
  23. 09 Jan, 2006 1 commit
  24. 31 Dec, 2005 3 commits
  25. 29 Dec, 2005 1 commit
  26. 26 Dec, 2005 1 commit
  27. 11 Dec, 2005 1 commit
  28. 10 Dec, 2005 1 commit
  29. 06 Dec, 2005 1 commit
  30. 05 Dec, 2005 2 commits
  31. 03 Dec, 2005 1 commit
  32. 02 Dec, 2005 1 commit