Verified Commit fdfa98a9 authored by Andrei Mateescu's avatar Andrei Mateescu
Browse files

fix: #3576262 [random test failure] MediaSourceFileTest::testMediaFileSource 

By: dries
By: donquixote
By: kentr
(cherry picked from commit 115e5e56)
parent f7a19fff

core/modules/media/tests/src/FunctionalJavascript/MediaSourceFileTest.php

+4 −2
Original line number Diff line number Diff line
@@ -54,6 +54,7 @@ public function testMediaFileSource(): void { 
    $page->selectFieldOption("field_map[" . File::METADATA_ATTRIBUTE_SIZE . "]", 'field_string_file_size');

    $page->selectFieldOption("field_map[" . File::METADATA_ATTRIBUTE_MIME . "]", 'field_string_mime_type');

    $page->pressButton('Save');

    $assert_session->waitForElement('css', '.messages--status');



    $test_filename = $this->randomMachineName() . '.txt';

    $test_filepath = 'public://' . $test_filename;
@@ -65,7 +66,7 @@ public function testMediaFileSource(): void { 
    $result = $assert_session->waitForButton('Remove');

    $this->assertNotEmpty($result);

    $page->pressButton('Save');



    $assert_session->waitForElement('css', '.messages--status');

    $assert_session->addressEquals('admin/content/media');



    // Get the media entity view URL from the creation message.
@@ -97,6 +98,7 @@ public function testMediaFileSource(): void { 
    $result = $assert_session->waitForButton('Remove');

    $this->assertNotEmpty($result);

    $page->pressButton('Save');

    $assert_session->waitForElement('css', '.messages--status');

    $assert_session->elementAttributeContains('css', 'img', 'src', 'text--plain.png');



    // Check if the mapped name is automatically updated.
@@ -111,10 +113,10 @@ public function testMediaFileSource(): void { 
    $result = $assert_session->waitForButton('Remove');

    $this->assertNotEmpty($result);

    $page->pressButton('Save');

    $assert_session->statusMessageContains("$new_filename has been updated.", 'status');

    /** @var \Drupal\media\MediaInterface $media */

    $media = \Drupal::entityTypeManager()->getStorage('media')->loadUnchanged(1);

    $this->assertEquals($new_filename, $media->getName());

    $assert_session->statusMessageContains("$new_filename has been updated.", 'status');

  }



}

core/modules/media/tests/src/FunctionalJavascript/MediaSourceTestBase.php

+1 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ public function doTestCreateMediaType($media_type_id, $source_id, array $provide 


    // Save the form to create the type.

    $page->pressButton('Save');

    $assert_session->waitForElement('css', '.messages--status');

    $assert_session->pageTextContains('The media type ' . $media_type_id . ' has been added.');

    $this->drupalGet('admin/structure/media');

    $assert_session->pageTextContains($media_type_id);