Unverified Commit fd2f9a07 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3160124 by jungle, jameszhang023, alexpott: Fix "wiget, escapeable, PHPunit" typos in Core 

(cherry picked from commit 0345c337)
(cherry picked from commit 275ac5ab)
parent e81a46dc

core/lib/Drupal/Core/Test/PhpUnitTestRunner.php

+1 −1
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ public function runTests($test_id, array $unescaped_test_classnames, &$status = 
        'test_id' => $test_id,

        'test_class' => implode(",", $unescaped_test_classnames),

        'status' => TestStatus::label($status),

        'message' => 'PHPunit Test failed to complete; Error: ' . implode("\n", $output),

        'message' => 'PHPUnit Test failed to complete; Error: ' . implode("\n", $output),

        'message_group' => 'Other',

        'function' => implode(",", $unescaped_test_classnames),

        'line' => '0',

core/modules/media_library/tests/src/FunctionalJavascript/ViewsUiIntegrationTest.php

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ public function testViewsAdmin() { 
    $page->find('css', '.js-media-library-view .view-filters')->pressButton('Apply filters');

    $this->waitForElementsCount('css', '.js-media-library-item', 1);



    // Test the same routine but in the view for the table wiget.

    // Test the same routine but in the view for the table widget.

    $this->drupalGet('/admin/structure/views/view/media_library/edit/widget_table');

    $this->waitForElementsCount('css', '.js-media-library-item', 8);

core/tests/Drupal/Tests/Component/Render/HtmlEscapedTextTest.php

+5 −5
Original line number Diff line number Diff line
@@ -21,9 +21,9 @@ class HtmlEscapedTextTest extends TestCase { 
   * @dataProvider providerToString

   */

  public function testToString($text, $expected, $message) {

    $escapeable_string = new HtmlEscapedText($text);

    $this->assertEquals($expected, (string) $escapeable_string, $message);

    $this->assertEquals($expected, $escapeable_string->jsonSerialize());

    $escapable_string = new HtmlEscapedText($text);

    $this->assertEquals($expected, (string) $escapable_string, $message);

    $this->assertEquals($expected, $escapable_string->jsonSerialize());

  }



  /**
@@ -57,8 +57,8 @@ public function providerToString() { 
   */

  public function testCount() {

    $string = 'Can I please have a <em>kitten</em>';

    $escapeable_string = new HtmlEscapedText($string);

    $this->assertEquals(strlen($string), $escapeable_string->count());

    $escapable_string = new HtmlEscapedText($string);

    $this->assertEquals(strlen($string), $escapable_string->count());

  }



}

core/tests/Drupal/Tests/Core/Test/PhpUnitTestRunnerTest.php

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ function ($unescaped_test_classnames, $phpunit_file, &$status) { 
      'test_id' => $test_id,

      'test_class' => 'SomeTest',

      'status' => TestStatus::label(TestStatus::EXCEPTION),

      'message' => 'PHPunit Test failed to complete; Error: ',

      'message' => 'PHPUnit Test failed to complete; Error: ',

      'message_group' => 'Other',

      'function' => 'SomeTest',

      'line' => '0',