Verified Commit fcc93f62 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #1899220 by lendude, larowlan, grisendo, quietone, dawehner, webchick,... 

Issue #1899220 by lendude, larowlan, grisendo, quietone, dawehner, webchick, smustgrave: Default to false "Place a colon after the label" views field setting
parent 03ef97f4

core/modules/user/tests/modules/user_test_views/test_views/views.view.test_user_changed.yml

+1 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ display: 
          table: users_field_data

          field: changed

          label: 'Updated date'

          element_label_colon: true

          plugin_id: field

          type: timestamp

          settings:

core/modules/views/src/Plugin/views/field/FieldPluginBase.php

+1 −1
Original line number Diff line number Diff line
@@ -529,7 +529,7 @@ protected function defineOptions() { 


    $options['element_label_type'] = ['default' => ''];

    $options['element_label_class'] = ['default' => ''];

    $options['element_label_colon'] = ['default' => TRUE];

    $options['element_label_colon'] = ['default' => FALSE];



    $options['element_wrapper_type'] = ['default' => ''];

    $options['element_wrapper_class'] = ['default' => ''];

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_table.yml

+1 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ display: 
          id: job

          relationship: none

          table: views_test_data

          element_label_colon: true

          plugin_id: string

        job_1:

          field: job

core/modules/views/tests/src/Kernel/Plugin/StyleTest.php

+3 −0
Original line number Diff line number Diff line
@@ -111,6 +111,7 @@ protected function doTestGrouping($stripped = FALSE): void { 
        'field' => 'name',

        'relationship' => 'none',

        'label' => 'Name',

        'element_label_colon' => TRUE,

      ],

      'job' => [

        'id' => 'job',
@@ -118,6 +119,7 @@ protected function doTestGrouping($stripped = FALSE): void { 
        'field' => 'job',

        'relationship' => 'none',

        'label' => 'Job',

        'element_label_colon' => TRUE,

      ],

      'age' => [

        'id' => 'age',
@@ -125,6 +127,7 @@ protected function doTestGrouping($stripped = FALSE): void { 
        'field' => 'age',

        'relationship' => 'none',

        'label' => 'Age',

        'element_label_colon' => TRUE,

      ],

    ];

    $view->displayHandlers->get('default')->overrideOption('fields', $fields);