Commit f8dbc98a authored by catch's avatar catch
Browse files

Issue #3195222 by smulvih2, ankithashetty, manish-31, larowlan, idebr,... 

Issue #3195222 by smulvih2, ankithashetty, manish-31, larowlan, idebr, longwave: Incorrect favicon rel attribute value - shortcut
parent 67bfb63d

core/modules/system/system.module

+1 −1
Changes for core/modules/system/system.module: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -597,7 +597,7 @@ function system_page_attachments(array &$page) { 
    $favicon = theme_get_setting('favicon.url');

    $type = theme_get_setting('favicon.mimetype');

    $page['#attached']['html_head_link'][][] = [

      'rel' => 'shortcut icon',

      'rel' => 'icon',

      'href' => UrlHelper::stripDangerousProtocols($favicon),

      'type' => $type,

    ];

core/modules/system/tests/src/Functional/Page/DefaultMetatagsTest.php

+3 −3
Changes for core/modules/system/tests/src/Functional/Page/DefaultMetatagsTest.php: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -29,9 +29,9 @@ public function testMetaTag() { 
    $result = $this->xpath('//meta');

    $this->assertEquals('utf-8', (string) $result[0]->getAttribute('charset'));



    // Ensure that the shortcut icon is on the page.

    $result = $this->xpath('//link[@rel = "shortcut icon"]');

    $this->assertCount(1, $result, 'The shortcut icon is present.');

    // Ensure that the icon is on the page.

    $result = $this->xpath('//link[@rel = "icon"]');

    $this->assertCount(1, $result, 'The icon is present.');

  }



}