Verified Commit f634e5af authored by Dave Long's avatar Dave Long
Browse files

Issue #3364204 by Sweetchuck: Locale configuration storage passes wrong...

Issue #3364204 by Sweetchuck: Locale configuration storage passes wrong arguments to install storage
parent 5f3e8885
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -129,8 +129,8 @@ public function listAll() {
  public function getComponentNames($type, array $list) {
    $names = array_unique(
      array_merge(
        array_keys($this->requiredInstallStorage->getComponentNames($type, $list)),
        array_keys($this->optionalInstallStorage->getComponentNames($type, $list))
        array_keys($this->requiredInstallStorage->getComponentNames($list)),
        array_keys($this->optionalInstallStorage->getComponentNames($list))
      )
    );
    if ($type == 'module' && in_array('language', $list)) {
+47 −0
Original line number Diff line number Diff line
<?php

declare(strict_types = 1);

namespace Drupal\Tests\locale\Kernel;

use Drupal\Core\Config\NullStorage;
use Drupal\KernelTests\KernelTestBase;
use Drupal\locale\LocaleDefaultConfigStorage;

/**
 * @group locale
 */
class LocaleDefaultConfigStorageTest extends KernelTestBase {

  protected static $modules = [
    'language',
    'locale',
    'locale_test',
    'locale_test_translate',
  ];

  public function testGetComponentNames(): void {
    $storage = new LocaleDefaultConfigStorage(
      new NullStorage(),
      \Drupal::languageManager(),
      'testing',
    );

    $expected = [
      'locale_test.no_translation',
      'locale_test.translation',
      'locale_test.translation_multiple',
      'locale_test_translate.settings',
      'block.block.test_default_config',
    ];
    $actual = $storage->getComponentNames(
      'module',
      [
        \Drupal::moduleHandler()->getModule('locale_test'),
        \Drupal::moduleHandler()->getModule('locale_test_translate'),
      ],
    );
    $this->assertSame($expected, $actual);
  }

}