Verified Commit f5cdfde1 authored by quietone's avatar quietone
Browse files

Issue #3490638 by tstoeckler, smustgrave: Add return types to update_test_* hooks 

(cherry picked from commit 0cd8c5c2)
parent 57a27fb2

core/.phpstan-baseline.php

+0 −204
Original line number Diff line number Diff line
@@ -39939,210 +39939,6 @@ 
	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_script_test/update_script_test.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_0_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_0/update_test_0.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_0_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_0/update_test_0.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_0_update_8003\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_0/update_test_0.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_1_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_1/update_test_1.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_1_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_1/update_test_1.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_1_update_8003\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_1/update_test_1.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_1_update_dependencies\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_1/update_test_1.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_2_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_2/update_test_2.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_2_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_2/update_test_2.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_2_update_8003\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_2/update_test_2.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_2_update_dependencies\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_2/update_test_2.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_3_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_3/update_test_3.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_3_update_dependencies\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_3/update_test_3.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_description_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_description/update_test_description.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_description_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_description/update_test_description.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_failing_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_failing/update_test_failing.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_failing_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_failing/update_test_failing.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_failing_post_update_first\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_failing/update_test_failing.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_invalid_hook_update_8000\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_invalid_hook/update_test_invalid_hook.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_last_removed_update_8003\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_last_removed/update_test_last_removed.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_no_preexisting_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_no_preexisting/update_test_no_preexisting.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_post_update_first\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_post_update_second\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_post_update_test0\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_post_update_test1\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_postupdate_post_update_test_batch\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_postupdate/update_test_postupdate.post_update.php',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_schema_requirements\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_schema/update_test_schema.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_schema_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_schema/update_test_schema.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_schema_update_8002\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_schema/update_test_schema.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_schema_update_8003\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_schema/update_test_schema.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_semver_update_n_update_8001\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_semver_update_n/update_test_semver_update_n.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_with_7x_update_7200\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_with_7x/update_test_with_7x.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Function update_test_with_7x_update_7201\\(\\) has no return type specified\\.$#',

	'count' => 1,

	'path' => __DIR__ . '/modules/system/tests/modules/update_test_with_7x/update_test_with_7x.install',

];

$ignoreErrors[] = [

	// identifier: missingType.return

	'message' => '#^Method Drupal\\\\Tests\\\\system\\\\Functional\\\\Batch\\\\ProcessingTest\\:\\:_resultMessages\\(\\) has no return type specified\\.$#',

core/modules/system/tests/modules/update_test_0/update_test_0.install

+3 −3
Original line number Diff line number Diff line
@@ -10,17 +10,17 @@ 
/**

 * Dummy update_test_0 update 8001.

 */

function update_test_0_update_8001() {

function update_test_0_update_8001(): void {

}



/**

 * Dummy update_test_0 update 8002.

 */

function update_test_0_update_8002() {

function update_test_0_update_8002(): void {

}



/**

 * Dummy update_test_0 update 8003.

 */

function update_test_0_update_8003() {

function update_test_0_update_8003(): void {

}

core/modules/system/tests/modules/update_test_1/update_test_1.install

+4 −4
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
 *

 * @see update_test_2_update_dependencies()

 */

function update_test_1_update_dependencies() {

function update_test_1_update_dependencies(): array {

  \Drupal::state()->set('update_test_1_update_dependencies_run', TRUE);

  // These dependencies are used in combination with those declared in

  // update_test_2_update_dependencies() for the sole purpose of testing that
@@ -41,17 +41,17 @@ function update_test_1_update_dependencies() { 
/**

 * Dummy update_test_1 update 8001.

 */

function update_test_1_update_8001() {

function update_test_1_update_8001(): void {

}



/**

 * Dummy update_test_1 update 8002.

 */

function update_test_1_update_8002() {

function update_test_1_update_8002(): void {

}



/**

 * Dummy update_test_1 update 8003.

 */

function update_test_1_update_8003() {

function update_test_1_update_8003(): void {

}

core/modules/system/tests/modules/update_test_2/update_test_2.install

+4 −4
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ 
 * @see update_test_1_update_dependencies()

 * @see update_test_3_update_dependencies()

 */

function update_test_2_update_dependencies() {

function update_test_2_update_dependencies(): array {

  // Combined with update_test_3_update_dependencies(), we are declaring here

  // that these two modules run updates in the following order:

  // 1. update_test_2_update_8001()
@@ -39,17 +39,17 @@ function update_test_2_update_dependencies() { 
/**

 * Dummy update_test_2 update 8001.

 */

function update_test_2_update_8001() {

function update_test_2_update_8001(): void {

}



/**

 * Dummy update_test_2 update 8002.

 */

function update_test_2_update_8002() {

function update_test_2_update_8002(): void {

}



/**

 * Dummy update_test_2 update 8003.

 */

function update_test_2_update_8003() {

function update_test_2_update_8003(): void {

}

core/modules/system/tests/modules/update_test_3/update_test_3.install

+2 −2
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
 *

 * @see update_test_2_update_dependencies()

 */

function update_test_3_update_dependencies() {

function update_test_3_update_dependencies(): array {

  $dependencies['update_test_3'][8001] = [

    'update_test_2' => 8001,

  ];
@@ -22,5 +22,5 @@ function update_test_3_update_dependencies() { 
/**

 * Dummy update_test_3 update 8001.

 */

function update_test_3_update_8001() {

function update_test_3_update_8001(): void {

}