Commit f5b86d3f authored by catch's avatar catch
Browse files

Issue #3266243 by mfb, longwave, catch: Views tries to call trigger_error()... 

Issue #3266243 by mfb, longwave, catch: Views tries to call trigger_error() with E_WARNING which throws a ValueError

(cherry picked from commit 76c529a6)
parent 77151633

core/modules/views/src/Plugin/views/style/Opml.php

+0 −4
Original line number Diff line number Diff line
@@ -55,10 +55,6 @@ public function attachTo(array &$build, $display_id, Url $feed_url, $title) { 
   * {@inheritdoc}

   */

  public function render() {

    if (empty($this->view->rowPlugin)) {

      trigger_error('Drupal\views\Plugin\views\style\Opml: Missing row plugin', E_WARNING);

      return [];

    }

    $rows = [];



    foreach ($this->view->result as $row_index => $row) {

core/modules/views/src/Plugin/views/style/Rss.php

+0 −4
Original line number Diff line number Diff line
@@ -107,10 +107,6 @@ public function getDescription() { 
  }



  public function render() {

    if (empty($this->view->rowPlugin)) {

      trigger_error('Drupal\views\Plugin\views\style\Rss: Missing row plugin', E_WARNING);

      return [];

    }

    $rows = [];



    // This will be filled in by the row plugin and is used later on in the

core/modules/views/src/Plugin/views/style/StylePluginBase.php

+0 −5
Original line number Diff line number Diff line
@@ -444,11 +444,6 @@ protected function renderRowGroup(array $rows = []) { 
   * Render the display in this style.

   */

  public function render() {

    if ($this->usesRowPlugin() && empty($this->view->rowPlugin)) {

      trigger_error('Drupal\views\Plugin\views\style\StylePluginBase: Missing row plugin', E_WARNING);

      return [];

    }



    // Group the rows according to the grouping instructions, if specified.

    $sets = $this->renderGrouping(

      $this->view->result,