Commit f4930ff6 authored by catch's avatar catch
Browse files

Issue #3421418 by mstrelan, Spokje, xjm, mondrake, longwave, acbramley: Add... 

Issue #3421418 by mstrelan, Spokje, xjm, mondrake, longwave, acbramley: Add void return typehints to all test methods
parent df0fb9b8

core/modules/action/tests/src/Functional/ActionListTest.php

+2 −2
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ class ActionListTest extends BrowserTestBase { 
  /**

   * Tests the behavior when there are no actions to list in the admin page.

   */

  public function testEmptyActionList() {

  public function testEmptyActionList(): void {

    // Create a user with permission to view the actions administration pages.

    $this->drupalLogin($this->drupalCreateUser(['administer actions']));
@@ -45,7 +45,7 @@ public function testEmptyActionList() { 
  /**

   * Tests that non-configurable actions can be created by the UI.

   */

  public function testNonConfigurableActionsCanBeCreated() {

  public function testNonConfigurableActionsCanBeCreated(): void {

    $this->drupalLogin($this->drupalCreateUser(['administer actions']));

    $this->drupalGet('/admin/config/system/actions');

    $this->assertSession()->elementExists('css', 'select > option[value="user_block_user_action"]');

core/modules/action/tests/src/Functional/ActionUninstallTest.php

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ class ActionUninstallTest extends BrowserTestBase { 
  /**

   * Tests Actions UI uninstall.

   */

  public function testActionUninstall() {

  public function testActionUninstall(): void {

    \Drupal::service('module_installer')->uninstall(['action']);



    $storage = $this->container->get('entity_type.manager')->getStorage('action');

core/modules/action/tests/src/Functional/ConfigurationTest.php

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ class ConfigurationTest extends BrowserTestBase { 
  /**

   * Tests configuration of advanced actions through administration interface.

   */

  public function testActionConfiguration() {

  public function testActionConfiguration(): void {

    // Create a user with permission to view the actions administration pages.

    $user = $this->drupalCreateUser(['administer actions']);

    $this->drupalLogin($user);

core/modules/action/tests/src/Functional/Node/NodeActionsConfigurationTest.php

+2 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ class NodeActionsConfigurationTest extends BrowserTestBase { 
  /**

   * Tests configuration of the node_assign_owner_action action.

   */

  public function testAssignOwnerNodeActionConfiguration() {

  public function testAssignOwnerNodeActionConfiguration(): void {

    // Create a user with permission to view the actions administration pages.

    $user = $this->drupalCreateUser(['administer actions']);

    $this->drupalLogin($user);
@@ -107,7 +107,7 @@ public function testAssignOwnerNodeActionConfiguration() { 
  /**

   * Tests the autocomplete field when configuring the AssignOwnerNode action.

   */

  public function testAssignOwnerNodeActionAutocomplete() {

  public function testAssignOwnerNodeActionAutocomplete(): void {

    // Create 200 users to force the action's configuration page to use an

    // autocomplete field instead of a select field. See

    // \Drupal\node\Plugin\Action\AssignOwnerNode::buildConfigurationForm().

core/modules/action/tests/src/FunctionalJavascript/ActionFormAjaxTest.php

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ protected function setUp(): void { 
  /**

   * Tests action plugins with AJAX save their configuration.

   */

  public function testActionConfigurationWithAjax() {

  public function testActionConfigurationWithAjax(): void {

    $url = Url::fromRoute('action.admin_add', ['action_id' => 'action_form_ajax_test']);

    $this->drupalGet($url);

    $page = $this->getSession()->getPage();