Commit f3bafe57 authored by xjm's avatar xjm

Issue #3037129 by tim.plunkett, andrewmacpherson, phenaproxima: Use distinct...

Issue #3037129 by tim.plunkett, andrewmacpherson, phenaproxima: Use distinct accessible names for the configure-section buttons in Layout Builder UI
parent 4c0e2146
...@@ -319,7 +319,7 @@ protected function buildAdministrativeSection(SectionStorageInterface $section_s ...@@ -319,7 +319,7 @@ protected function buildAdministrativeSection(SectionStorageInterface $section_s
], ],
'configure' => [ 'configure' => [
'#type' => 'link', '#type' => 'link',
'#title' => $this->t('Configure section'), '#title' => $this->t('Configure section <span class="visually-hidden">@section</span>', ['@section' => $delta + 1]),
'#access' => $layout instanceof PluginFormInterface, '#access' => $layout instanceof PluginFormInterface,
'#url' => Url::fromRoute('layout_builder.configure_section', [ '#url' => Url::fromRoute('layout_builder.configure_section', [
'section_storage_type' => $storage_type, 'section_storage_type' => $storage_type,
......
...@@ -301,8 +301,8 @@ public function testConfigurableLayoutSections() { ...@@ -301,8 +301,8 @@ public function testConfigurableLayoutSections() {
$assert_session->linkExists('Add Block'); $assert_session->linkExists('Add Block');
// Configure the existing section. // Configure the existing section.
$assert_session->linkExists('Configure section'); $assert_session->linkExists('Configure section 1');
$this->clickLink('Configure section'); $this->clickLink('Configure section 1');
$this->assertOffCanvasFormAfterWait('layout_builder_configure_section'); $this->assertOffCanvasFormAfterWait('layout_builder_configure_section');
$page->fillField('layout_settings[setting_1]', 'Test setting value'); $page->fillField('layout_settings[setting_1]', 'Test setting value');
$page->pressButton('Update'); $page->pressButton('Update');
......
...@@ -94,8 +94,8 @@ public function testWidthChange() { ...@@ -94,8 +94,8 @@ public function testWidthChange() {
$this->assertWidthClassApplied($width_option['class'] . $width); $this->assertWidthClassApplied($width_option['class'] . $width);
foreach ($width_option['widths'] as $width) { foreach ($width_option['widths'] as $width) {
$width_class = $width_option['class'] . $width; $width_class = $width_option['class'] . $width;
$assert_session->linkExists('Configure section'); $assert_session->linkExists('Configure section 1');
$page->clickLink('Configure section'); $page->clickLink('Configure section 1');
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-off-canvas input[type="submit"][value="Update"]')); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-off-canvas input[type="submit"][value="Update"]'));
$page->findField('layout_settings[column_widths]')->setValue($width); $page->findField('layout_settings[column_widths]')->setValue($width);
$page->pressButton("Update"); $page->pressButton("Update");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment