Issue #3415321 by Spokje, mondrake: Refactor...

<?php

namespace Drupal\FunctionalTests\Test;

use Drupal\Tests\BrowserTestBase;

/**

 * Helper test for FunctionalTestDebugHtmlOutputTest.

 *

 * @see \Drupal\FunctionalTests\Test\FunctionalTestDebugHtmlOutputTest::testFunctionalTestDebugHtmlOutput

 *

 * @group browsertestbase

 */

class FunctionalTestDebugHtmlOutputHelperTest extends BrowserTestBase {

  /**

   * {@inheritdoc}

   */

  protected $defaultTheme = 'stark';

  /**

   * Creates one page of debug HTML output.

   */

  public function testCreateFunctionalTestDebugHtmlOutput(): void {

    $this->drupalGet('<front>');

  }

}

<?php

namespace Drupal\FunctionalTests\Test;

use Drupal\Tests\BrowserTestBase;

use Symfony\Component\Process\Process;

/**

 * Test to ensure that functional tests produce debug HTML output when required.

 *

 * @group browsertestbase

 */

class FunctionalTestDebugHtmlOutputTest extends BrowserTestBase {

  /**

   * {@inheritdoc}

   */

  protected $defaultTheme = 'stark';

  /**

   * Ensures that functional tests produce debug HTML output when required.

   *

   * Note: this test must be a BrowserTestBase to ensure all requirements for

   * running a functional test are met.

   */

  public function testFunctionalTestDebugHtmlOutput(): void {

    // Test with the specified output directory.

    $process = Process::fromShellCommandline('vendor/bin/phpunit --configuration core --verbose core/tests/Drupal/FunctionalTests/Test/FunctionalTestDebugHtmlOutputHelperTest.php');

    $process->setWorkingDirectory($this->root)

      ->setTimeout(300)

      ->setIdleTimeout(300);

    $process->run();

    $this->assertEquals(0, $process->getExitCode(),

      'COMMAND: ' . $process->getCommandLine() . "\n" .

      'OUTPUT: ' . $process->getOutput() . "\n" .

      'ERROR: ' . $process->getErrorOutput() . "\n");

    $this->assertStringContainsString('HTML output was generated', $process->getOutput());

    $this->assertStringContainsString('Drupal_FunctionalTests_Test_FunctionalTestDebugHtmlOutputHelperTest', $process->getOutput());

    // Test with a wrong output directory.

    $process = Process::fromShellCommandline('vendor/bin/phpunit --configuration core --verbose core/tests/Drupal/FunctionalTests/Test/FunctionalTestDebugHtmlOutputHelperTest.php');

    $process->setWorkingDirectory($this->root)

      ->setTimeout(300)

      ->setIdleTimeout(300);

    $process->run(NULL, ['BROWSERTEST_OUTPUT_DIRECTORY' => 'can_we_assume_that_a_subdirectory_with_this_name_does_not_exist']);

    $this->assertEquals(0, $process->getExitCode(),

      'COMMAND: ' . $process->getCommandLine() . "\n" .

      'OUTPUT: ' . $process->getOutput() . "\n" .

      'ERROR: ' . $process->getErrorOutput() . "\n");

    $this->assertStringContainsString('HTML output directory can_we_assume_that_a_subdirectory_with_this_name_does_not_exist is not a writable directory.', $process->getOutput());

  }

}

    );

  }

  /**

   * Ensures that functional tests produce debug HTML output when required.

   */

  public function testFunctionalTestDebugHtmlOutput() {

    if (!getenv('BROWSERTEST_OUTPUT_DIRECTORY')) {

      $this->markTestSkipped('This test requires the environment variable BROWSERTEST_OUTPUT_DIRECTORY to be set.');

    }

    // Test with the specified output directory.

    $process = Process::fromShellCommandline('vendor/bin/phpunit --configuration core --verbose core/modules/image/tests/src/Functional/ImageDimensionsTest.php');

    $process->setWorkingDirectory($this->root)

      ->setTimeout(300)

      ->setIdleTimeout(300);

    $process->run();

    $this->assertEquals(0, $process->getExitCode(),

      'COMMAND: ' . $process->getCommandLine() . "\n" .

      'OUTPUT: ' . $process->getOutput() . "\n" .

      'ERROR: ' . $process->getErrorOutput() . "\n");

    $this->assertStringContainsString('HTML output was generated', $process->getOutput());

    $this->assertStringContainsString('Drupal_Tests_image_Functional_ImageDimensionsTest', $process->getOutput());

    // Test with a wrong output directory.

    $process = Process::fromShellCommandline('vendor/bin/phpunit --configuration core --verbose core/modules/image/tests/src/Functional/ImageDimensionsTest.php');

    $process->setWorkingDirectory($this->root)

      ->setTimeout(300)

      ->setIdleTimeout(300);

    $process->run(NULL, ['BROWSERTEST_OUTPUT_DIRECTORY' => 'can_we_assume_that_a_subdirectory_with_this_name_does_not_exist']);

    $this->assertEquals(0, $process->getExitCode(),

      'COMMAND: ' . $process->getCommandLine() . "\n" .

      'OUTPUT: ' . $process->getOutput() . "\n" .

      'ERROR: ' . $process->getErrorOutput() . "\n");

    $this->assertStringContainsString('HTML output directory can_we_assume_that_a_subdirectory_with_this_name_does_not_exist is not a writable directory.', $process->getOutput());

  }

}