Verified Commit f276622c authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3376376 by Charlie ChX Negyesi, andypost:... 

Issue #3376376 by Charlie ChX Negyesi, andypost: HelpSectionManager::clearCachedDefinitions breaks the update system
parent a3433391

core/modules/help/help.module

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ function _help_search_update(array $extensions = []): void { 
    return;

  }



  if (\Drupal::service('update.update_hook_registry')->getInstalledVersion('help') >= 10100) {

  if (\Drupal::service('update.update_hook_registry')->getInstalledVersion('help') >= 10200) {

    // Ensure that topics for extensions that have been uninstalled are removed

    // and that the index state variable is updated.

    $help_search = \Drupal::service('plugin.manager.search')->createInstance('help_search');

core/modules/help/src/HelpSectionManager.php

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ public function setSearchManager(?PluginManagerInterface $search_manager = NULL) 
  public function clearCachedDefinitions() {

    parent::clearCachedDefinitions();

    $version = \Drupal::service('update.update_hook_registry')->getInstalledVersion('help');

    if ($this->searchManager && $version >= 10100) {

    if ($this->searchManager && $version >= 10200) {

      // Rebuild the index on cache clear so that new help topics are indexed

      // and any changes due to help topics edits or translation changes are

      // picked up.