Commit ee60b69f authored by catch's avatar catch
Browse files

fix: #3557459 Tests trigger deprecations in... 

fix: #3557459 Tests trigger deprecations in \Drupal\views\Plugin\views\field\FieldPluginBase::getRenderTokens on PHP 8.5

By: @alexpott
(cherry picked from commit 819b0627)
parent d5420b3a

core/modules/views/tests/src/Functional/Handler/FieldWebTest.php

+2 −0
Original line number Diff line number Diff line
@@ -252,6 +252,7 @@ public function testAlterUrl(): void { 
    $view->initHandlers();

    $this->executeView($view);

    $row = $view->result[0];

    $view->row_index = 0;

    $id_field = $view->field['id'];



    // Setup the general settings required to build a link.
@@ -577,6 +578,7 @@ public function testTextRendering(): void { 
    $name_field->options['alter']['alter_text'] = TRUE;

    $name_field->options['alter']['text'] = $html_text = '<div class="views-test">' . $random_text . '</div>';

    $row = $view->result[0];

    $view->row_index = 0;



    $name_field->options['alter']['strip_tags'] = TRUE;

    $output = (string) $renderer->executeInRenderContext(new RenderContext(), function () use ($name_field, $row) {

core/modules/views/tests/src/Kernel/Handler/FieldDropbuttonTest.php

+2 −1
Original line number Diff line number Diff line
@@ -136,7 +136,8 @@ public function testDropbuttonMarkupShouldNotLeakBetweenRows(): void { 


    // Render each row and field in turn - the dropbutton plugin relies on

    // output being set in previous versions.

    foreach ($view->result as $row) {

    foreach ($view->result as $index => $row) {

      $view->row_index = $index;

      foreach (array_keys($view->field) as $field) {

        $output = $renderer->executeInRenderContext(new RenderContext(), function () use ($view, $row, $field) {

          return $view->field[$field]->advancedRender($row);

core/modules/views/tests/src/Kernel/Handler/FieldKernelTest.php

+6 −1
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ public function testRewrite(): void { 
    $view->initHandlers();

    $this->executeView($view);

    $row = $view->result[0];

    $view->row_index = 0;

    $id_field = $view->field['id'];



    // Don't check the rewrite checkbox, so the text shouldn't appear.
@@ -173,6 +174,7 @@ public function testRewriteHtmlWithTokens(): void { 
    $view->initHandlers();

    $this->executeView($view);

    $row = $view->result[0];

    $view->row_index = 0;

    $id_field = $view->field['id'];



    $id_field->options['alter']['text'] = '<p>{{ id }}</p>';
@@ -205,6 +207,7 @@ public function testRewriteHtmlWithTokensAndAggregation(): void { 
    $view->initHandlers();

    $this->executeView($view);

    $row = $view->result[0];

    $view->row_index = 0;

    $id_field = $view->field['id'];



    $id_field->options['alter']['text'] = '<p>{{ id }}</p>';
@@ -240,6 +243,7 @@ public function testArgumentTokens(): void { 
    $name_field_0->options['alter']['text'] = '%1 !1';



    $row = $view->result[0];

    $view->row_index = 1;

    $output = (string) $renderer->executeInRenderContext(new RenderContext(), function () use ($name_field_0, $row) {

      return $name_field_0->advancedRender($row);

    });
@@ -284,7 +288,8 @@ public function testFieldTokens(): void { 
    $name_field_2->options['alter']['alter_text'] = TRUE;

    $name_field_2->options['alter']['text'] = '{% if name_2|length > 3 %}{{ name_2 }} {{ name_1 }}{% endif %}';



    foreach ($view->result as $row) {

    foreach ($view->result as $index => $row) {

      $view->row_index = $index;

      $expected_output_0 = $row->views_test_data_name;

      $expected_output_1 = "$row->views_test_data_name $row->views_test_data_name";

      $expected_output_2 = "$row->views_test_data_name $row->views_test_data_name $row->views_test_data_name";

core/modules/views/tests/src/Kernel/Handler/FieldSelfTokensTest.php

+1 −0
Original line number Diff line number Diff line
@@ -56,6 +56,7 @@ public function testSelfTokenEscaping(): void { 
    $view->initHandlers();

    $this->executeView($view);

    $row = $view->result[0];

    $view->row_index = 0;

    $title_field = $view->field['title'];

    $title_field->options['alter']['text'] = '<p>{{ title__value }}</p>';

    $title_field->options['alter']['alter_text'] = TRUE;