Issue #3281444 by ravi.shankar, _shY, nod_, Vighneshh, deviantintegral,...

Issue #3281444 by ravi.shankar, _shY, nod_, Vighneshh, deviantintegral, lauriii: Update Installer tests to not use Bartik and Seven

(cherry picked from commit a223aa1c)

core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php

@@ -38,7 +38,7 @@ protected function prepareEnvironment() {
       'distribution' => [
         'name' => 'My Distribution',
         'install' => [
-          'theme' => 'bartik',
+          'theme' => 'olivero',
         ],
       ],
     ];

core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTest.php

@@ -32,7 +32,7 @@ protected function prepareEnvironment() {
       'distribution' => [
         'name' => 'My Distribution',
         'install' => [
-          'theme' => 'bartik',
+          'theme' => 'claro',
           'finish_url' => '/root-user',
         ],
       ],

core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationQueryTest.php

@@ -43,7 +43,7 @@ protected function prepareEnvironment() {
         'name' => 'My Distribution',
         'langcode' => $this->langcode,
         'install' => [
-          'theme' => 'bartik',
+          'theme' => 'claro',
         ],
       ],
     ];

core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationTest.php

@@ -45,7 +45,7 @@ protected function prepareEnvironment() {
         'name' => 'My Distribution',
         'langcode' => $this->langcode,
         'install' => [
-          'theme' => 'bartik',
+          'theme' => 'claro',
         ],
       ],
     ];

core/tests/Drupal/FunctionalTests/Installer/InstallerTest.php

@@ -53,7 +53,7 @@ public function testInstaller() {
   protected function setUpLanguage() {
     // Test that \Drupal\Core\Render\BareHtmlPageRenderer adds assets and
     // metatags as expected to the first page of the installer.
-    $this->assertSession()->responseContains("core/themes/claro/css/components/button.css");
+    $this->assertSession()->responseContains("css/components/button.css");
     $this->assertSession()->responseContains('<meta charset="utf-8" />');
 
     // Assert that the expected title is present.

core/tests/Drupal/FunctionalTests/Installer/MultipleDistributionsProfileTest.php

@@ -37,7 +37,7 @@ protected function prepareEnvironment() {
         'distribution' => [
           'name' => $name,
           'install' => [
-            'theme' => 'bartik',
+            'theme' => 'claro',
           ],
         ],
       ];
@@ -57,7 +57,7 @@ protected function setUpLanguage() {
     // Verify that the distribution name appears.
     $this->assertSession()->pageTextContains('distribution_one');
     // Verify that the requested theme is used.
-    $this->assertSession()->responseContains('bartik');
+    $this->assertSession()->responseContains('claro');
     // Verify that the "Choose profile" step does not appear.
     $this->assertSession()->pageTextNotContains('profile');
 

core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php

@@ -29,7 +29,7 @@ public function testInstaller() {
   protected function setUpSite() {
     // Test that the correct theme is being used.
     $this->assertSession()->responseNotContains('olivero');
-    $this->assertSession()->responseContains('themes/claro/css/theme/install-page.css');
+    $this->assertSession()->responseContains('css/theme/install-page.css');
     parent::setUpSite();
   }
 

core/themes/olivero/olivero.theme

@@ -23,7 +23,7 @@ function olivero_preprocess_html(&$variables) {
   }
 
   // Convert custom hex to hsl so we can use the hue value
-  $brand_color_hex = theme_get_setting('base_primary_color');
+  $brand_color_hex = theme_get_setting('base_primary_color') ?? '#1b9ae4';
   [$h, $s, $l] = _olivero_hex_to_hsl($brand_color_hex);
 
   $variables['html_attributes']->setAttribute('style', "--color--primary-hue:$h;--color--primary-saturation:$s%;--color--primary-lightness:$l");
@@ -633,7 +633,7 @@ function olivero_form_views_exposed_form_alter(&$form) {
  *
  * @internal
  */
-function _olivero_hex_to_hsl($hex_string) {
+function _olivero_hex_to_hsl(string $hex_string) {
   // Convert hexcode pairs to rgb values (0-255).
   $hex_val = trim($hex_string, '#');
   $r0 = hexdec($hex_val[0] . $hex_val[1]);