Verified Commit ecd67af7 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #2941148 by quietone, bruno.bicudo, ravi.shankar, Sweetchuck,...

Issue #2941148 by quietone, bruno.bicudo, ravi.shankar, Sweetchuck, beatrizrodrigues, lucienchalom, VitaliyB98, WagnerMelo, sophiavs, ankitjain28may, daffie, longwave, Sutharsan, borisson_, cosmicdreams, heykarthikwithu, catch: Fix Drupal.Commenting.FunctionComment.MissingReturnType

(cherry picked from commit b8ac0d98)
parent 7069578e
Loading
Loading
Loading
Loading
+3 −3
Changes for core/includes/common.inc: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ function drupal_attach_tabledrag(&$element, array $options) {
 * @param $element
 *   The element to be hidden.
 *
 * @return
 * @return array
 *   The element.
 *
 * @see \Drupal\Core\Render\RendererInterface
@@ -390,7 +390,7 @@ function hide(&$element) {
 * @param $element
 *   The element to be shown.
 *
 * @return
 * @return array
 *   The element.
 *
 * @see \Drupal\Core\Render\RendererInterface
@@ -564,7 +564,7 @@ function drupal_get_updaters() {
/**
 * Assembles the Drupal FileTransfer registry.
 *
 * @return
 * @return array
 *   The Drupal FileTransfer class registry.
 *
 * @see \Drupal\Core\FileTransfer\FileTransfer
+1 −1
Changes for core/includes/errors.inc: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ function _drupal_error_handler_real($error_level, $message, $filename, $line) {
 * @param $error
 *   Optional error to examine for ERROR_REPORTING_DISPLAY_SOME.
 *
 * @return
 * @return bool
 *   TRUE if an error should be displayed.
 */
function error_displayable($error = NULL) {
+2 −2
Changes for core/includes/form.inc: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ function form_select_options($element, $choices = NULL) {
 * @param $key
 *   The key to look for.
 *
 * @return
 * @return array|bool
 *   An array of indexes that match the given $key. Array will be
 *   empty if no elements were found. FALSE if optgroups were found.
 */
@@ -1011,7 +1011,7 @@ function _batch_populate_queue(&$batch, $set_id) {
 * @param $batch_set
 *   The batch set.
 *
 * @return
 * @return \Drupal\Core\Queue\QueueInterface|null
 *   The queue object.
 */
function _batch_queue($batch_set) {
+16 −19
Changes for core/includes/install.core.inc: 16 added lines, 19 removed lines.
Original line number Diff line number Diff line
@@ -549,7 +549,7 @@ function install_begin_request($class_loader, &$install_state) {
 *   (optional) A callback to allow command line processes to update a progress
 *   bar. The callback is passed the $install_state variable.
 *
 * @return
 * @return array|null
 *   HTML output from the last completed task.
 */
function install_run_tasks(&$install_state, callable $callback = NULL) {
@@ -606,7 +606,7 @@ function install_run_tasks(&$install_state, callable $callback = NULL) {
 *   An array of information about the current installation state. This is
 *   passed in by reference so that it can be modified by the task.
 *
 * @return
 * @return array|null
 *   The output of the task function, if there is any.
 */
function install_run_task($task, &$install_state) {
@@ -709,7 +709,7 @@ function install_run_task($task, &$install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   A list of tasks to be performed, with associated metadata.
 */
function install_tasks_to_perform($install_state) {
@@ -745,7 +745,7 @@ function install_tasks_to_perform($install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   A list of tasks, with associated metadata as returned by
 *   hook_install_tasks().
 */
@@ -906,7 +906,7 @@ function install_tasks($install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   A list of tasks, with keys equal to the machine-readable task name and
 *   values equal to the name that should be displayed.
 *
@@ -979,7 +979,7 @@ function install_get_form($form_id, array &$install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return string
 *   The URL to redirect to.
 *
 * @see install_full_redirect_url()
@@ -994,7 +994,7 @@ function install_redirect_url($install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return string
 *   The complete URL to redirect to.
 *
 * @see install_redirect_url()
@@ -1072,7 +1072,7 @@ function install_display_output($output, $install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   A themed status report, or an exception if there are requirement errors.
 */
function install_verify_requirements(&$install_state) {
@@ -1118,7 +1118,7 @@ function install_base_system(&$install_state) {
/**
 * Verifies and returns the last installation task that was completed.
 *
 * @return
 * @return null|string
 *   The last completed task, if there is one. An exception is thrown if Drupal
 *   is already installed.
 */
@@ -1222,7 +1222,7 @@ function install_database_errors($database, $settings_file) {
 *   profile will be added here, if it was not already selected previously, as
 *   will a list of all available profiles.
 *
 * @return
 * @return array|null
 *   For interactive installations, a form allowing the profile to be selected,
 *   if the user has a choice that needs to be made. Otherwise, an exception is
 *   thrown if a profile cannot be chosen automatically.
@@ -1310,7 +1310,7 @@ function _install_select_profile(&$install_state) {
/**
 * Finds all .po files that are useful to the installer.
 *
 * @return
 * @return array
 *   An associative array of file URIs keyed by language code. URIs as
 *   returned by FileSystemInterface::scanDirectory().
 *
@@ -1341,7 +1341,7 @@ function install_find_translations() {
 *   langcode will be added here, if it was not already selected previously, as
 *   will a list of all available languages.
 *
 * @return
 * @return array|null
 *   For interactive installations, a form or other page output allowing the
 *   language to be selected or providing information about language selection,
 *   if a language has not been chosen. Otherwise, an exception is thrown if a
@@ -1558,7 +1558,7 @@ function install_bootstrap_full() {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   The batch definition.
 */
function install_profile_modules(&$install_state) {
@@ -1667,7 +1667,7 @@ function install_install_profile(&$install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   The batch definition, if there are language files to download.
 */
function install_download_additional_translations_operations(&$install_state) {
@@ -1718,7 +1718,7 @@ function install_download_additional_translations_operations(&$install_state) {
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array|null
 *   The batch definition, if there are language files to import.
 */
function install_import_translations(&$install_state) {
@@ -1848,9 +1848,6 @@ function install_finish_translations(&$install_state) {
 *
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 *   A message informing the user that the installation is complete.
 */
function install_finished(&$install_state) {
  $profile = $install_state['parameters']['profile'];
@@ -2260,7 +2257,7 @@ function install_check_requirements($install_state) {
 *   An array of requirements, in the same format as is returned by
 *   hook_requirements().
 *
 * @return
 * @return array|null
 *   A themed status report, or an exception if there are requirement errors.
 *   If there are only requirement warnings, a themed status report is shown
 *   initially, but the user is allowed to bypass it by providing 'continue=1'
+11 −11
Changes for core/includes/install.inc: 11 added lines, 11 removed lines.
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ function drupal_load_updates() {
/**
 * Loads the installation profile, extracting its defined distribution name.
 *
 * @return
 * @return string
 *   The distribution name defined in the profile's .info.yml file. Defaults to
 *   "Drupal" if none is explicitly provided by the installation profile.
 *
@@ -145,7 +145,7 @@ function drupal_install_profile_distribution_version() {
/**
 * Detects all supported databases that are compiled into PHP.
 *
 * @return
 * @return array
 *   An array of database types compiled into PHP.
 */
function drupal_detect_database_types() {
@@ -529,7 +529,7 @@ function _drupal_rewrite_settings_dump_one(\stdClass $variable, $prefix = '', $s
 * @param $install_state
 *   An array of information about the current installation state.
 *
 * @return
 * @return array
 *   The list of modules to install.
 */
function drupal_verify_profile($install_state) {
@@ -663,7 +663,7 @@ function drupal_install_system($install_state) {
 *   (optional) Determines whether to attempt fixing the permissions according
 *   to the provided $mask. Defaults to TRUE.
 *
 * @return
 * @return bool
 *   TRUE on success or FALSE on failure. A message is set for the latter.
 */
function drupal_verify_install_file($file, $mask = NULL, $type = 'file', $autofix = TRUE) {
@@ -752,7 +752,7 @@ function drupal_verify_install_file($file, $mask = NULL, $type = 'file', $autofi
 * @param $message
 *   (optional) Whether to output messages. Defaults to TRUE.
 *
 * @return
 * @return bool
 *   TRUE/FALSE whether or not the directory was successfully created.
 */
function drupal_install_mkdir($file, $mask, $message = TRUE) {
@@ -803,7 +803,7 @@ function drupal_install_mkdir($file, $mask, $message = TRUE) {
 * @param $message
 *   (optional) Whether to output messages. Defaults to TRUE.
 *
 * @return
 * @return bool
 *   TRUE/FALSE whether or not we were able to fix the file's permissions.
 */
function drupal_install_fix_file($file, $mask, $message = TRUE) {
@@ -906,7 +906,7 @@ function install_goto($path) {
 * @param $query
 *   (optional) An array of query parameters to merge in to the existing ones.
 *
 * @return
 * @return string
 *   The URL of the current script, with query parameters modified by the
 *   passed-in $query. The URL is not sanitized, so it still needs to be run
 *   through \Drupal\Component\Utility\UrlHelper::filterBadProtocol() if it will be
@@ -935,7 +935,7 @@ function drupal_current_script_url($query = []) {
 *   The severity of the requirements problem, as returned by
 *   drupal_requirements_severity().
 *
 * @return
 * @return string
 *   A URL for attempting to proceed to the next step of the script. The URL is
 *   not sanitized, so it still needs to be run through
 *   \Drupal\Component\Utility\UrlHelper::filterBadProtocol() if it will be used
@@ -1010,7 +1010,7 @@ function drupal_check_profile($profile) {
 *   An array of requirements, in the same format as is returned by
 *   hook_requirements().
 *
 * @return
 * @return int
 *   The highest severity in the array.
 */
function drupal_requirements_severity(&$requirements) {
@@ -1029,7 +1029,7 @@ function drupal_requirements_severity(&$requirements) {
 * @param $module
 *   Machine name of module to check.
 *
 * @return
 * @return bool
 *   TRUE or FALSE, depending on whether the requirements are met.
 */
function drupal_check_module($module) {
@@ -1107,7 +1107,7 @@ function drupal_check_module($module) {
 * @param $langcode
 *   Language code (if any).
 *
 * @return
 * @return array
 *   The info array.
 */
function install_profile_info($profile, $langcode = 'en') {
Loading