Skip to content
Snippets Groups Projects
Unverified Commit e977788e authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3480293 by gapple: ConfigTarget::__construct() documentation references...

Issue #3480293 by gapple: ConfigTarget::__construct() documentation references incorrect ToConfig enum name

(cherry picked from commit ba24f059)
(cherry picked from commit c26c5ee4)
parent 4b330801
No related branches found
No related tags found
5 merge requests!12802Issue #3537193 by opauwlo: Add enable absolute path option for CKEditor5 image uploads,!12684Issue #3220784,!12523Issue #3493858 by vidorado, xavier.masson, smustgrave: Extend ViewsBlockBase...,!122353526426-warning-for-missing,!8559#3450868 Add ViewsConfigUpdater deprecation support for default_argument_skip_url
Pipeline #339553 passed
......@@ -74,8 +74,8 @@ final class ConfigTarget {
* return an array with the transformed values, also keyed by property path.
* The callback will receive the form state object as its second argument.
* The callback may return a special values:
* - ToConfig::NoMapping, to indicate that the given form value does not
* need to be mapped onto the Config object
* - ToConfig::NoOp, to indicate that the given form value does not need to
* be mapped onto the Config object
* - ToConfig::DeleteKey to indicate that the targeted property path should
* be deleted from config.
* Defaults to NULL.
......@@ -237,7 +237,7 @@ public function setValue(Config $config, mixed $value, FormStateInterface $form_
}
// Set the returned value, or if a special value (one of the cases in the
// ConfigTargetValue enum): apply the appropriate action.
// ToConfig enum): apply the appropriate action.
array_walk($value, fn (mixed $value, string $property) => match ($value) {
// No-op.
ToConfig::NoOp => NULL,
......
......@@ -286,14 +286,14 @@ public function testSingleTarget(): void {
$config->set('something', FALSE)->shouldBeCalledTimes(1);
$config_target->setValue($config->reveal(), 'No', $this->prophesize(FormStateInterface::class)->reveal());
// Test `ConfigTargetValue::NoMapping`: nothing should happen to the Config.
// Test `ToConfig::NoOp`: nothing should happen to the Config.
$config = $this->prophesize(Config::class);
$config->getName()->willReturn('foo.settings');
$config->set('something', Argument::any())->shouldBeCalledTimes(0);
$config->clear('something', Argument::any())->shouldBeCalledTimes(0);
$config_target->setValue($config->reveal(), '<test:noop>', $this->prophesize(FormStateInterface::class)->reveal());
// Test `ConfigTargetValue::DeleteKey`: Config::clear() should be called.
// Test `ToConfig::DeleteKey`: Config::clear() should be called.
$config = $this->prophesize(Config::class);
$config->getName()->willReturn('foo.settings');
$config->clear('something')->shouldBeCalledTimes(1);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment