Verified Commit e851b339 authored by Dave Long's avatar Dave Long
Browse files

Issue #3424768 by mfb, OMD, cilefen, smustgrave: Channel description of RSS feeds is double-escaped 

(cherry picked from commit e8db570e)
parent 00edfd5f

core/lib/Drupal/Core/EventSubscriber/RssResponseRelativeUrlFilter.php

+6 −4
Original line number Diff line number Diff line
@@ -57,12 +57,14 @@ protected function transformRootRelativeUrlsToAbsolute($rss_markup, Request $req 


    // Invoke Html::transformRootRelativeUrlsToAbsolute() on all HTML content

    // embedded in this RSS feed.

    foreach ($rss_dom->getElementsByTagName('description') as $node) {

    foreach ($rss_dom->getElementsByTagName('item') as $item) {

      foreach ($item->getElementsByTagName('description') as $node) {

        $html_markup = $node->nodeValue;

        if (!empty($html_markup)) {

          $node->replaceChild($rss_dom->createTextNode(Html::transformRootRelativeUrlsToAbsolute($html_markup, $request->getSchemeAndHttpHost())), $node->firstChild);

        }

      }

    }



    return $rss_dom->saveXML();

  }

core/tests/Drupal/Tests/Core/EventSubscriber/RssResponseRelativeUrlFilterTest.php

+2 −2
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ public function providerTestOnResponse() { 
<channel>

  <title>Drupal.org</title>

  <link>https://www.drupal.org</link>

  <description>Come for the software, stay for the community

  <description>Come for the software &amp; stay for the community

Drupal is an open source content management platform powering millions of websites and applications. It’s built, used, and supported by an active and diverse community of people around the world.</description>

  <language>en</language>

  <item>
@@ -45,7 +45,7 @@ public function providerTestOnResponse() { 
<channel>

  <title>Drupal.org</title>

  <link>https://www.drupal.org</link>

  <description>Come for the software, stay for the community

  <description>Come for the software &amp; stay for the community

Drupal is an open source content management platform powering millions of websites and applications. It’s built, used, and supported by an active and diverse community of people around the world.</description>

  <language>en</language>

  <item>